Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListResultPrinter / Add template arguments parameter, refs 972 #2024

Merged
merged 1 commit into from
Nov 19, 2016

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Nov 19, 2016

This PR is made in reference to: #972, [0]

This PR addresses or contains:

  • Adds the template arguments parameter with 'numbered', 'named', 'legacy' where numbered being {{{1}}}, named is interpret as {{{Has test}}}, and legacy to require the ? {{{?Has text}}} which is equal to named args
  • named args is used with priority (to avoid any incompatibilities with existing output) even in cases where |template arguments=named is denoted

This PR includes:

  • Tests (unit/integration)
  • CI build passed

[0] https://semantic-mediawiki.org/wiki/Thread:Help_talk:Template_format/Clarifying_something_with_named_args

@mwjames mwjames added this to the SMW 2.5 milestone Nov 19, 2016
@mwjames
Copy link
Contributor Author

mwjames commented Nov 19, 2016

@kghbln FYI

@mwjames mwjames merged commit 05e3265 into master Nov 19, 2016
@mwjames mwjames deleted the templ-name branch November 19, 2016 12:19
@kghbln kghbln added the wikidocu missing Code changes (mostly features) what have not yet been documented label Nov 19, 2016
@mwjames
Copy link
Contributor Author

mwjames commented Nov 19, 2016

@kghbln kghbln mentioned this pull request Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wikidocu missing Code changes (mostly features) what have not yet been documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants