-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for MW 1.41, 1.42 and 1.43 #122
Conversation
paladox
commented
Dec 18, 2024
•
edited
Loading
edited
- Updates PageForm to 5.9 due to issues with 5.3/5.5. 5.9 supports MW 1.39+.
- Fix tests for MW 1.43. Replace PHPUnit_Framework_TestCase with \PHPUnit\Framework\TestCase.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #122 +/- ##
=========================================
Coverage 60.26% 60.26%
Complexity 103 103
=========================================
Files 8 8
Lines 526 526
Branches 44 44
=========================================
Hits 317 317
Misses 168 168
Partials 41 41 ☔ View full report in Codecov by Sentry. |
@gesinn-it-gea for some reason it’s stuck on 1.42 stuck on: --- AfterCreateTablesComplete (Hook) -------------------------------------- |
yes, I noticed this as well. Maybe we re-run and see what happens. |
I did that but seems to have still happened and stuck at the same place. |
yes got stuck again |
maybe same as: SemanticMediaWiki/SemanticMediaWiki#5675 |
... but the comment in SemanticMediaWiki/SemanticMediaWiki#5675 to re-run does not seem a real solution |
Re-trying it for us doesn’t seem to work. I’ve re-tried the test 3 times and it has now gotten stuck 3 times. |
Maybe PF is causing an issue. Currently, the Makefile statically installs PageForms v5.5.1 https://github.com/SemanticMediaWiki/SemanticFormsSelect/blob/master/Makefile#L21 I think it would be good to add PF to the CI matrix instead of having a pinned version in the Makefile. |