Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for MW 1.41, 1.42 and 1.43 #122

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Add tests for MW 1.41, 1.42 and 1.43 #122

merged 4 commits into from
Dec 18, 2024

Conversation

paladox
Copy link
Contributor

@paladox paladox commented Dec 18, 2024

  • Updates PageForm to 5.9 due to issues with 5.3/5.5. 5.9 supports MW 1.39+.
  • Fix tests for MW 1.43. Replace PHPUnit_Framework_TestCase with \PHPUnit\Framework\TestCase.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.26%. Comparing base (f8df1c7) to head (88a573a).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #122   +/-   ##
=========================================
  Coverage     60.26%   60.26%           
  Complexity      103      103           
=========================================
  Files             8        8           
  Lines           526      526           
  Branches         44       44           
=========================================
  Hits            317      317           
  Misses          168      168           
  Partials         41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paladox
Copy link
Contributor Author

paladox commented Dec 18, 2024

@gesinn-it-gea for some reason it’s stuck on 1.42

stuck on:

--- AfterCreateTablesComplete (Hook) --------------------------------------
Task(s) registered via the hook depend on the functionality implemented and
may take a moment to complete.
-------------------------------------------------------- Import task(s) ---
Importing from smw.search.json …

@gesinn-it-gea
Copy link
Member

yes, I noticed this as well. Maybe we re-run and see what happens.

@paladox
Copy link
Contributor Author

paladox commented Dec 18, 2024

yes, I noticed this as well. Maybe we re-run and see what happens.

I did that but seems to have still happened and stuck at the same place.

@gesinn-it-gea
Copy link
Member

yes got stuck again

@gesinn-it-gea
Copy link
Member

maybe same as: SemanticMediaWiki/SemanticMediaWiki#5675

@gesinn-it-gea
Copy link
Member

... but the comment in SemanticMediaWiki/SemanticMediaWiki#5675 to re-run does not seem a real solution

@paladox
Copy link
Contributor Author

paladox commented Dec 18, 2024

... but the comment in SemanticMediaWiki/SemanticMediaWiki#5675 to re-run does not seem a real solution

Re-trying it for us doesn’t seem to work. I’ve re-tried the test 3 times and it has now gotten stuck 3 times.

@gesinn-it-gea
Copy link
Member

Maybe PF is causing an issue.

Currently, the Makefile statically installs PageForms v5.5.1 https://github.com/SemanticMediaWiki/SemanticFormsSelect/blob/master/Makefile#L21

I think it would be good to add PF to the CI matrix instead of having a pinned version in the Makefile.

@paladox
Copy link
Contributor Author

paladox commented Dec 18, 2024

@gesinn-it-gea Seems you are correct! https://github.com/SemanticMediaWiki/SemanticFormsSelect/actions/runs/12396929160/job/34606104274?pr=125

@gesinn-it-gea gesinn-it-gea merged commit d2cc5e2 into master Dec 18, 2024
6 checks passed
@paladox paladox deleted the paladox-patch-2 branch December 18, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants