Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argument 2 passed to SMW\ApprovedRevs\Hooks::onChangeRevision() must be an instance of Revision or null #27

Closed
gesinn-it-gea opened this issue Mar 9, 2022 · 1 comment · Fixed by #28
Closed

Argument 2 passed to SMW\ApprovedRevs\Hooks::onChangeRevision() must be an instance of Revision or null #27

gesinn-it-gea opened this issue Mar 9, 2022 · 1 comment · Fixed by #28
Assignees
@gesinn-it-wam
Labels
bug Something isn't working
Milestone
0.9.2

Comments

@gesinn-it-gea
Copy link
Member

Setup and configuration

  • SMW version: 4.0.0
  • AR: 1.7.3
  • SAR version: 0.9.1
  • MW version: 1.35
  • DB (MySQL etc.): MySQL

Issue

Produces an Internal Error on approve

[247416eeaad4471190c0c8c5] /index.php?title=Main_Page&action=approve&oldid=1 TypeError from line 172 of /var/www/html/extensions/SemanticApprovedRevs/src/Hooks.php: Argument 2 passed to SMW\ApprovedRevs\Hooks::onChangeRevision() must be an instance of Revision or null, instance of MediaWiki\Revision\RevisionStoreRecord given, called in /var/www/html/includes/HookContainer/HookContainer.php on line 329

Backtrace:

#0 /var/www/html/includes/HookContainer/HookContainer.php(329): SMW\ApprovedRevs\Hooks->onChangeRevision(Title, MediaWiki\Revision\RevisionStoreRecord)
#1 /var/www/html/includes/HookContainer/HookContainer.php(132): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)

Steps to reproduce the observation:

  • Vanilla Wiki with default Main Page
  • Login as WikiSysop
  • Approve "Main Page"
@gesinn-it-gea gesinn-it-gea added the bug Something isn't working label Mar 9, 2022
@gesinn-it-gea gesinn-it-gea added this to the 0.9.2 milestone Mar 9, 2022
gesinn-it-wam added a commit that referenced this issue Mar 15, 2022
@gesinn-it-wam
add integration test to demonstrate #27 (only working for Sqlite)
814ef54
@gesinn-it-wam
Copy link
Contributor

Reproduced the issue by a integration test: https://github.com/SemanticMediaWiki/SemanticApprovedRevs/runs/5551416471?check_suite_focus=true#step:10:155

gesinn-it-wam added a commit that referenced this issue Mar 15, 2022
@gesinn-it-wam
fix #27 by updating the signature of Hooks::onChangeRevision
e472be2
@gesinn-it-wam gesinn-it-wam mentioned this issue Mar 15, 2022
Merged
gesinn-it-wam added a commit that referenced this issue Mar 15, 2022
@gesinn-it-wam
Fix Issue 27 (#28)
41a9609 
* add integration test to demonstrate #27
* fix #27 by updating the signature of Hooks::onChangeRevision
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gesinn-it-wam gesinn-it-wam

Labels
bug Something isn't working
Projects
None yet
Milestone
0.9.2
Development

Successfully merging a pull request may close this issue.

Fix Issue 27 SemanticMediaWiki/SemanticApprovedRevs
2 participants
@gesinn-it-gea @gesinn-it-wam