Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Theme]: allow null @site #6876

Merged
merged 1 commit into from
May 26, 2020
Merged

[Theme]: allow null @site #6876

merged 1 commit into from
May 26, 2020

Conversation

cruzdanilo
Copy link
Contributor

[Theme]: allow null @site

allow "null" values for @site theme config variable, like all other variables already allow.
as the default theme is always imported, using "null" values for all variables decreases dramatically the bundle size by avoiding duplicates when using default theme. this improvement is noticeable even when using optimizers like cssnano.

ps: i am calling "null" values that cause the optional import not to find any file.

@jlukic jlukic changed the base branch from master to next May 26, 2020 01:39
@jlukic
Copy link
Member

jlukic commented May 26, 2020

This looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants