Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icons] FA5 Report #6226

Merged
merged 7 commits into from
Mar 18, 2018
Merged

[Icons] FA5 Report #6226

merged 7 commits into from
Mar 18, 2018

Conversation

y0hami
Copy link
Member

@y0hami y0hami commented Feb 27, 2018

Reported FA5 using a new method so that the icons can use the FA5 font files. It also allows the ability to enable/disable solid, outline and brand icons so you can choose which icons you want in your theme. This method also eliminates the risk of bugs.

The method is using a much more reliable script to do the port and it does checks with the FA5 icon metafiles to include all icons with the correct Unicode characters. It also does a check to include all the old semantic aliases with much higher accuracy. It also builds to docs categories to the exact match of the FA5 website since it scrapes the site for which icons belong in which category.

I also added the new icons from yesterdays patch to FA5 5.0.7 (medical and logistics)

Sean Hamilton added 3 commits February 27, 2018 14:29
Icons now use FA5 font files
New variables to enable/disable solid, outline and brand icons
@y0hami y0hami added this to the 2.3.1 milestone Feb 27, 2018
y0hami pushed a commit to Semantic-Org/Semantic-UI-Docs that referenced this pull request Feb 27, 2018
@y0hami
Copy link
Member Author

y0hami commented Feb 27, 2018

This is the PR for the docs page Semantic-Org/Semantic-UI-Docs#383

@jlukic
Copy link
Member

jlukic commented Feb 28, 2018

There's merge conflicts in your pull request

@jlukic
Copy link
Member

jlukic commented Feb 28, 2018

We cant remove any existing variables like @fontName this will break any custom themes.

@jlukic
Copy link
Member

jlukic commented Mar 14, 2018

I'll get this in, this weekend.

This was referenced Mar 15, 2018
Sean Hamilton added 2 commits March 16, 2018 15:23
Fixed a bug with icons with link in the name
Deleted the old icon files from assets
Updated to FA 5.0.8
Renamed line to linechat to stop conflicts
y0hami pushed a commit to Semantic-Org/Semantic-UI-Docs that referenced this pull request Mar 17, 2018
jlukic added a commit that referenced this pull request Mar 18, 2018
…f override). Use existing names to avoid backwards compatability issues #6226
jlukic added a commit that referenced this pull request Mar 18, 2018
…ns if not loaded (except brand which would require a refactor) #6226
@jlukic jlukic merged commit c1a450d into Semantic-Org:next Mar 18, 2018
@jlukic
Copy link
Member

jlukic commented Mar 18, 2018

I've reworked this so as to not break any backwards compatibility.

Overview of changes

  • Kept existing src/icon definition from 2.3.0
  • Renamed regular to outline
  • Moved brand/outline to overrides
  • Made solid-icons, icons
  • Moved the content: definitions for outline to importOutlineFont conditional
  • Moved brand definitions into importBrandFont conditional

My largest concern with this refactor is making sure that people using custom fonts arent affected, and that they arent loading additional font files by default. This is mostly accomplished by moving the custom code over to the overrides file. I've also made sure to preserve the current @src rules as they may be using these to define font locations.

An added benefit of this setup, if @importOutlineFont is set to false all the icons will load the correct solid style from main font.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants