-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Icons] FA5 Report #6226
[Icons] FA5 Report #6226
Conversation
Icons now use FA5 font files New variables to enable/disable solid, outline and brand icons
…to fa5-report Merged next
Updated to match the new PR Semantic-Org/Semantic-UI#6226
This is the PR for the docs page Semantic-Org/Semantic-UI-Docs#383 |
There's merge conflicts in your pull request |
We cant remove any existing variables like |
I'll get this in, this weekend. |
Fixed a bug with icons with link in the name Deleted the old icon files from assets Updated to FA 5.0.8 Renamed line to linechat to stop conflicts
Added new changes from Semantic-Org/Semantic-UI#6226
…f override). Use existing names to avoid backwards compatability issues #6226
…ns if not loaded (except brand which would require a refactor) #6226
I've reworked this so as to not break any backwards compatibility. Overview of changes
My largest concern with this refactor is making sure that people using custom fonts arent affected, and that they arent loading additional font files by default. This is mostly accomplished by moving the custom code over to the An added benefit of this setup, if |
Reported FA5 using a new method so that the icons can use the FA5 font files. It also allows the ability to enable/disable solid, outline and brand icons so you can choose which icons you want in your theme. This method also eliminates the risk of bugs.
The method is using a much more reliable script to do the port and it does checks with the FA5 icon metafiles to include all icons with the correct Unicode characters. It also does a check to include all the old semantic aliases with much higher accuracy. It also builds to docs categories to the exact match of the FA5 website since it scrapes the site for which icons belong in which category.
I also added the new icons from yesterdays patch to FA5 5.0.7 (medical and logistics)