Fix #3486: [Menu] Pointing tip color in inverted pointing menu #6216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice fix 👍 |
exoego
force-pushed
the
pointing-tip-in-inverted
branch
2 times, most recently
from
5a13ce1
to
349b01b
Compare
exoego
force-pushed
the
pointing-tip-in-inverted
branch
from
349b01b
to
1909b01
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions. |
|
Closing this since this had been kept unattended for long time. 😥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed Issues
#3486
Description
Currently, pointing tips of
.active.itemin.inverted.pointing.menuare all black. Those looks incosistent to tips in non-inverted pointing menu.This PR lets pointing tips can reflect a color of parent (
.active.item), when those are in.inverted.pointing.menu.Testcase
https://jsfiddle.net/z0vzw26e/3/