Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown] Fix #5231 Clicking on the dropdown icon will generate multiple hits to the server (when no results are returned) #5809

Closed
wants to merge 1 commit into from

Conversation

vpeti
Copy link

@vpeti vpeti commented Sep 25, 2017

I resolved the loop by adding the noResults message in queryRemote (which is specific to this scenario, so it seemed appropriate) if the length of results is zero

@stale
Copy link

stale bot commented Feb 22, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 22, 2018
@vpeti
Copy link
Author

vpeti commented Feb 23, 2018

Please accept.

@stale stale bot removed the stale label Feb 23, 2018
@laja
Copy link

laja commented Apr 13, 2018

This is a bugfix, we are also affected. Could someone please look into it?

jlukic added a commit that referenced this pull request Jun 18, 2018
@jlukic
Copy link
Member

jlukic commented Jun 18, 2018

I've added a solve in next patch, that is similar in style to this PR. Credit in release notes.

@lokesh1990
Copy link

lokesh1990 commented Jul 17, 2018

I am not sure if I should post this as a new bug.
I receive the array as an object.

So, from @jlukic fix,
hasRemoteValues = ($.isArray(values) && values.length > 0)
is set to false because of isArray.

Do you think it could be replaced by
hasRemoteValues = !$.isEmptyObject(values) ?
Or do you really have to check if it is an array?

My object would look like
{ 0 : {name: "test", text: "test", value: "101"} }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants