menu/search: remove border-radius #5282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `border-radius` property in the search input was cutting of parts of the first letter in the prompt. The prompt class name seems to be needed from the example in the docs[1] so resetting the `border-radius` for a search prompt when it's in a menu component seems like the most straight-forward solution. [1]: https://semantic-ui.com/collections/menu.html#search Closes Semantic-Org#5281
|
I wasn't able to get the semantic docs up and running on my machine so this is somewhat untested but just point me to the correct place and I'll add tests and whatnot more needed to get this merged. This fiddle seems to indicate that the fix is good. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
border-radiusproperty in the search input was cutting of parts ofthe first letter in the prompt.
The prompt class name seems to be needed from the example in the docs1
so resetting the
border-radiusfor a search prompt when it's in a menucomponent seems like the most straight-forward solution.
Closes #5281