-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: auto install did not copy build during npm install #4430
Conversation
…t the source path - otherwise semantic.json was overwritten during npm install (autoInstall:true)
More testing needed. |
Can you elaborate on what's going on here. The purpose of this fix, what's behaving abnormally about |
When auto Install is true, npm install does not copy out the files to the base directory (E.g. semantic/) and call gulp build. These changes builds the base directory specified in semantic.json and calls gulp build. I closed the PR for now to do more testing because I realised that I haven't tested all the semantic.json options. |
but... it is not copying over..... my wonderful CI ... broken into pieces because of the semantic-ui step... when will this be fixed? |
My wonderful Strider CI is broken too :( |
Added 'build' option in semantic.json to control whether gulp build is ran after autoinstall |
👍 without these proposed fixes autoInstall is broken and will not copy the files. Please merge this ASAP. |
Please fix this... it's broken on our DeployBot setup due to being unable to install via |
This causes my install to fail with TypeError: Path must be a string. Received undefined
at assertPath (path.js:7:11)
at Object.join (path.js:1211:7)
at Gulp.<anonymous> (/home/jack/semantic/ui/tasks/install.js:277:26)
at module.exports (/home/jack/semantic/ui/node_modules/orchestrator/lib/runTask.js:34:7)
at Gulp.Orchestrator._runTask (/home/jack/semantic/ui/node_modules/orchestrator/index.js:273:3)
at Gulp.Orchestrator._runStep (/home/jack/semantic/ui/node_modules/orchestrator/index.js:214:10)
at Gulp.Orchestrator.start (/home/jack/semantic/ui/node_modules/orchestrator/index.js:134:8)
at runNextSet (/home/jack/semantic/ui/node_modules/run-sequence/index.js:86:16)
at Gulp.onTaskEnd (/home/jack/semantic/ui/node_modules/run-sequence/index.js:75:5)
at emitOne (events.js:101:20) Currently debugging |
I've modified the install script to avoid the copying when running from |
With 'autoInstall: true' in semantic.json, npm install does not copy out the semantic files to root directory.
The following check always fails when install.shouldAutoInstall() === true