Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix #1554, modified .ui.segment.attached to fix content pane bleeding #1557

Closed
wants to merge 1 commit into from

Conversation

UiCandy
Copy link

@UiCandy UiCandy commented Jan 3, 2015

Minor fix for issue #1554, as described by @mxth, here: http://jsfiddle.net/6murnr7n/20/

Changing .ui.segment.attached { width: calc(100% + 2px) } to .ui.segment.attached { width:100% } thus ensuring there's no bleed on the content pane and it aligns itself to the nav perfectly.

Cheers,
Rishav S

@MohammadYounes
Copy link
Member

You should not be changing dist/semantic.css, this file is the result of building semantic source files.

The source file for segment element is located here and the variable for the default theme is located here

@UiCandy
Copy link
Author

UiCandy commented Jan 4, 2015

Thanks for that Mohammad,
I'll submit an updated version tomorrow. Cheers!

Sent from my iPhone. Please excuse any errors.

On Jan 4, 2015, at 3:07 PM, "Mohammad Younes" [email protected] wrote:

You should not be changing dist/semantic.css, this file is the result of building semantic source files.

The source file for segment element is located here and the variable for the default theme is located here


Reply to this email directly or view it on GitHub.

@MohammadYounes
Copy link
Member

I think you should revise it again, as your update fixes the issue with the tabular menu, but it does not work well with other attached segments, see http://jsfiddle.net/j1vdakx5/

@UiCandy
Copy link
Author

UiCandy commented Jan 5, 2015

Thanks for simulating that behavior, I'm going to look at it with a greater level of detail and push it.

Cheers,
Rishav S

Sent from my iPhone. Please excuse any errors.

On Jan 4, 2015, at 6:38 PM, "Mohammad Younes" [email protected] wrote:

I think you should revise it again, as your update fixes the issue with the tabular menu, but it does not work well with other attached segments, see http://jsfiddle.net/j1vdakx5/


Reply to this email directly or view it on GitHub.

@jlukic
Copy link
Member

jlukic commented Jan 5, 2015

The difficulty is aligning different ui elements that have borders created using box-shadow and border. The adjacent sibling selector .ui.tabular.menu ~ .segment will also match other segments later in content flow, as long as they are on the same level. So its a bit course and can also cause issues.

I'm not sure of any good way to go forward other than requiring a special class on attached tab segments.

@jlukic
Copy link
Member

jlukic commented Jan 8, 2015

Continued in #1587. This solution was not adequate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants