Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the issue where gulp build was not building all css files #6622… #6631

Conversation

himanshu230
Copy link

Issue Titles

[Build Tools] Fixes gulp build not building all css files

Closed Issues

#6622 #6067

Description

Inside css.js gulp build file, compressedStream was set by piping stream to clone(). But later on, that variable was again set. It means that the initial compressedStream was left open, which caused backpressure and paused the original stream. As a result, all css files were not built. Solved the issue by removing the first open stream.

@charlycou
Copy link

I had to modify print = require('gulp-print'), to print = require('gulp-print').default, to make it work from my setup.

@ccit-spence
Copy link

ccit-spence commented Oct 19, 2018

Tested and this fixed the issue I had with no css file being generated - V2.4.1

Did not have to modify print = require('gulp-print') only used changes from the PR.

@jlukic jlukic added this to the 2.4.2 milestone Oct 21, 2018
@jlukic
Copy link
Member

jlukic commented Oct 21, 2018

22a0c7b

The compressed cloned stream was still referencing the original stream. With the gulp dependency updates this is causing issues.

 compressedStream = stream
    .pipe(plumber())
   /* etc

it should just be

 compressedStream
    .pipe(plumber())
   /* etc

I've verified this fix should resolve issues by using the following to test

  1. Create new directory fake/
  2. Run npm install --save semantic-org/semantic-ui#next
  3. cd semantic then gulp build
  4. Confirm all files are in dist/

jlukic added a commit that referenced this pull request Oct 21, 2018
@jlukic
Copy link
Member

jlukic commented Oct 21, 2018

I'm cutting a new release now thanks for your help identifying the problem @himanshu230

@jlukic jlukic closed this Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants