Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gulp build is not building semantic.min.css #6067

Closed
nestorvanz opened this issue Jan 3, 2018 · 38 comments
Closed

gulp build is not building semantic.min.css #6067

nestorvanz opened this issue Jan 3, 2018 · 38 comments
Milestone

Comments

@nestorvanz
Copy link

nestorvanz commented Jan 3, 2018

In a fresh installation i am running "gulp build" but in the "dist" folder is not present semantic.min.css, theres only the semantic.min.js, "components" and "themes" folder.

@novalevel
Copy link

I also have this issue

@himanshu230
Copy link

himanshu230 commented Jan 3, 2018

I had the same issue
I solved it by changing the build-css gulp task.
In file tasks/build/css.js in semantic folder, remove the following line
compressedStream = stream.pipe(clone());

@nestorvanz
Copy link
Author

What are the changes that you made? @himanshu230

@himanshu230
Copy link

@nestorvanz There is a file /tasks/build/css.js. Search for line
compressedStream = stream.pipe(clone());
Removing that line seems to solve the issue.
It might be because later on, compressedStream is again set, which means that this clone stream is not piped to anything, creating backpressure.

@jjshammas
Copy link

Hmm…that file hasn't changed since July 2016…

mayfield added a commit to ForstaLabs/forsta-web-messenger that referenced this issue Jan 4, 2018
For some reason semantic stopped working in heroku and for a lot of
other people too.

Semantic-Org/Semantic-UI#6067
@Rex90
Copy link

Rex90 commented Jan 4, 2018

Been trying to figure out what I'm doing wrong all morning. Is this an issue with the semantic-ui release?

@y0hami
Copy link
Member

y0hami commented Jan 4, 2018

@Rex90 This problem started after an update for gulp-clone was released.

I made a pull request this morning with a fix so hopefully it gets merged. You can do a temporary fix by commenting out a line as @himanshu230 mentioned in his comment.

@fsworld009
Copy link

fsworld009 commented Jan 4, 2018

I manually changed gulp-clone to 1.0.0 and remove that line as @himanshu230 suggested but still cannot get any css file after gulp build command. Any idea?

Both Semantic UI (2.2.13) and gulp CLI (3.9.1) are the latest.

EDIT: never mind, I was messing around with theme.config and forgot to revert it back, looks like gulp won't show any error message when there is error in theme.config

@specimen151
Copy link

specimen151 commented Jan 9, 2018

Not a fix, but:
I have found that it might have something to do with the file size. At least these are my findings:

Editing semantic.json, the "components" array, and removing e.g. half of the components will build the css with no problem. Test with gulp build-css. You can remove whichever components you want (removing one is not enough), so that's why I think it has something to do with the total size of if.

@fsworld009
Copy link

@specimen151 I think it might also because you forgot to specify the theme for certain components (or you put an invalid theme name?) in theme.config but you included those components in "components" array, which causes the build script fail. At least for me I am able to build all components into one css file.

@specimen151
Copy link

@fsworld009 Could be, however I if I change the gulp-clone version to 1.0.0 or uncomment the clone line, like suggested above, it all works. And it also worked fine (clean install, no modifications) two weeks ago. I looked at the new gulp-clone, and there has been many changes there to the underlying dependencies. Maybe they don't work the same.

And also I am (w/o any mods) able to build all components, but not all at the same time. E.g. I specify the first half of the list of every component, builds fine. Then I replace with the second half of the list (of every component) and it builds fine. But when I have like 70% or more of the complete list of components, it seems like there is some buffer that's full or something, because it won't build, and it doesn't matter which components I remove... Anyway the above suggestions/pull-requests works for me.

@truesteps
Copy link

So, how is this coming along? Any fix without actually modifying the source files in npm? Can I somehow force the package to use gulp-clone 1.0.0??

@specimen151
Copy link

Is @himanshu230 's fix of removing compressedStream = stream.pipe(clone()); maybe better than staying with the old version of gulp-clone? The stream is set to a new stream just a few lines down anyway, so it seems unnecessary.

@truesteps
Copy link

truesteps commented Jan 12, 2018

I fixed this by generating a npm shrinkwrap with the gulp clone version 1.0.0 fixed the issue for me @specimen151 this might help you, change the version of gulp-clone in semantic-ui package.json from ^1.0.0 to 1.0.0 in node_modules, generate a npm shrinkwrap (basically a package-lock with locked versions of packages and their dependencies), npm install inside semantic-ui folder in node_modules than you just do a clean npm install in the root folder of your projects package.json and it will generate a shrinkwrap with the correct version. From what i've read npm install first looks into shrinkwrap before installing and installs the versions specified inside shrinkwrap

@mathewjoe
Copy link

A cleaner fix IMO would be to simply install gulp-clone 1.0.0 as a dependency for your project, till a fix is released. This will replace the newer v1.1.1 that was installed by default.

npm i [email protected] --save-exact

@truesteps
Copy link

truesteps commented Jan 12, 2018

@disrupticons true, i tried installing the dependency myself and reinstalled modules and it didn't work but seems like I just forgot to delete something and it didn't build really well, this is a much better solution

@jayphelps
Copy link
Contributor

jayphelps commented Jan 15, 2018

This was fixed upstream in mariocasciaro/gulp-clone#7 and mariocasciaro/gulp-clone#8. Released as gulp-clone 1.1.3.

You may have to blow away your node_modules to pick it up.

@specimen151
Copy link

So the issue could be closed then? Maybe @nestorvanz must do it?

@y0hami
Copy link
Member

y0hami commented Jan 16, 2018

I can confirm the new gulp-clone update did fix this. I am also going to close my PR.

@jlukic
Copy link
Member

jlukic commented Jan 29, 2018

I've updated the project's package.json so it should fix any stale node_modules

@jjshammas
Copy link

In gulp-clone v2+, this seems to happen again!

@jayphelps
Copy link
Contributor

@jjshammas that's correct. The change they did was shifted from breaking 1.0 to 2.0. Semantic still uses v1

"gulp-clone": "^1.1.3",

dalhyncarrillo added a commit to dalhyncarrillo/Semantic-UI that referenced this issue Mar 10, 2018
* Support modification of 'closable' setting while modal is open

* [Dropdown] Allow ignoring of case when getting an item

Currently get.item compares labels and values case sensitively. This can cause duplicates when `allowAdditions` is `true`. To prevent these duplicates get.item should be capable of comparing labels and values while ignoring case.

However the current behaviour should be preserved by default.

To achieve this a new setting is added called `ignoresCase`, which when `true` will disregard the casing of labels and string values when performing the comparision.

* Fixed an issue where all child inputs of a icon input would recieve a right padding, not just the main input. This caused issues where a popup was attached to the icon input which caused all of the inputs inside of it to have an uneeded padding.

* Update form.js

Semantic-Org#4422

* Take content settings before attr title

* Fix inverted dimmer text color

The definition referenced the wrong variable.

* Added `box-shadow` to the checkbox component’s `.toggle` variation

* The width of inputs that are inside of a dropdown’s `.menu` should never be overridden

* default 'prompt' message has mistakes in writing

 line 1266 - 1269 : correct 'must' to 'cannot', etc..

* Revert the changes and increase the selector’s specificity.

* Fix horizontal scrollbar height, closes Semantic-Org#5728

* [Buttons] fix for active basic button text color always having a lower specificity due to !important

* Add link to webpage at top of README

I was looking for the link for way too long...

* Fix issue with bottomPassed and topPassed

* Added onChanging callback to accordion

Because it's useful

* Swap huge and big in menu.variables Semantic-Org#5899

* Swap bigWidth with hugeWidth in sizes Semantic-Org#5899

* [Flag] Add England Flag and Alias

* Fix issue where dropdowns might animate outward two times on blur

* Rlsnotes

* Fix error which could cause popup to use wrong offset context when specifying popup manually

* Rlsnotes popup

* Fix for Semantic-Org#5713

[Form Validation] regression: get values with radio returns true or false Semantic-Org#5713

* Use @background value for arrow background color

* Changed gulp-clone version (Fixes Semantic-Org#6067)

New update to gulp-clone breaks CSS build task

* Added .idea for PhpStorm and WebStorm

* Made a complete port of FA5 with all new icons
Added sui aliases for current icons
Added new aliases for old icons which no longer exist to help with compatibility

* Updated YouTube colour

Updated the YouTube colour to the new red.

https://www.youtube.com/intl/en-GB/yt/about/brand-resources/

* Fix Semantic-Org#5366, Semantic-Org#5975, taken from @dannyBies

* Semantic-Org#5366, Semantic-Org#5975 - Fixes open rightward/leftward incorrectly adjusting to scroll context

* Update gulp-clone dep with issue Semantic-Org#6067 Semantic-Org#6089

* Update rlsnotes

* Semantic-Org#5366, Semantic-Org#5975 - Fixes issue with offset not available on window

* Update rlsnotes

* Semantic-Org#6043 Semantic-Org#5713 code formatting

* Rlsnotes Semantic-Org#6043, Semantic-Org#5713, 6067

* Adds coupling for ribbon label with reveal Semantic-Org#5681

* Release notes Semantic-Org#5681

* Fix issue with scrolling modal and allowMultiple Semantic-Org#2423

* Rlsnotes Semantic-Org#5097

* Rlsnotes Semantic-Org#5530

* Rlsnotes

* Add coupling for lists inside menus, fix box shadow showing as border Semantic-Org#5603

* Add additional weight to link list states Semantic-Org#5603

* Rlsnotes Semantic-Org#5603

* Revert "[Dropdown] Allow ignoring of case when getting an item"

* Semantic-Org#3432 implement matching user addition case

* Semantic-Org#3432 Simplifies setting name (derp), adds default to false

* Add issue links

* Update dist to 2.2.14

* Regen package-lock

* Update rlsnotes for 2.2.14

* Typos in release notes

* Fix element structure

Change end tag from </div> to </h4> to correctly match opening tag

* Remove href attribute from div element

* Remove closing </div> element for which no opening elements exists

* Updated to 2.2.14 file which fixes the gulp-clone bug

* Fixed all broken icons, changed some names and updated to 5.0.6
Added `elementor` icon
Added `youtube-square` icon
Added `window-minimize` icon
Added `chess` icon
Added `chess bishop` icon
Added `chess board` icon
Added `chess king` icon
Added `chess knight` icon
Added `chess pawn` icon
Added `chess queen` icon
Added `chess rock` icon
Added `square full` icon
Added `baseball ball` icon
Added `basketball ball` icon
Added `bowling ball` icon
Added `football ball` icon
Added `futbol` icon
Added `futbol outline` icon
Added `golf ball` icon
Added `hocky puck` icon
Added `quidditch` icon
Added `table tennis` icon
Added `volleyball ball` icon
Fixed `cloud download alternate` icon
Fixed `cloud upload alternate` icon
Fixed `external link square alternate` icon
Fixed `pencil alternate` icon
Fixed `window close` icon
Fixed `window restore outline` icon
Fixed `images` icon
Fixed `500px` icon
Fixed `accessible icon` icon
Fixed `accusoft` icon
Fixed `app store ios` icon
Fixed `apper` icon
Fixed `asymmetrik` icon
Fixed `audible` icon
Fixed `avianex` icon
Fixed `aws` icon
Fixed `bimobject` icon
Fixed `bitcoin` icon
Fixed `centercode` icon
Fixed `cloudscale` icon
Fixed `cloudsmith` icon
Fixed `cloudversify` icon
Fixed `cpanel` icon
Fixed `digital ocean` icon
Fixed `discord` icon
Fixed `discourse` icon
Fixed `dochub` icon
Fixed `docker` icon
Fixed `draft2digital` icon
Fixed `dribbble square` icon
Fixed `dyalog` icon
Fixed `fly` icon
Fixed `uber` icon
Fixed `uikit` icon
Fixed `uniregistry` icon
Fixed `untappd` icon
Fixed `ussunnah` icon
Fixed `vaadin` icon
Fixed `viber` icon
Fixed `wordpress simple` icon
Fixed `xbox` icon
Fixed `yandex international` icon
Fixed `yandex` icon
Renamed `list ol` to `ordered list`
Renamed `list ul` to `unordered list`
Renamed `user md` to `user doctor`
Renamed `cc amex` to `credit card american express`
Renamed `cc *` to `credit card *`
Renamed `red river` to `redriver`

* Add missing comma: makes 9 global vars local

* Update README.md

* Fix bug with autofocus modifying focus of modal fields

* Correctly calculate offset when popup is in a different positioning context

* Add arrow centering on small popups

* Add centered dimmers and modals

* Fixes alignment of dimmer

* Updates to ui search to allow local category search, and responsive name width

* Semantic-Org#6085 dedupe icons from FA5 port

* Rlsnotes on icons

* Username typo

* Rlsnotes Semantic-Org#6127

* Rlsnotes Semantic-Org#6059

* Add font weight global variables

* Thanks Semantic-Org#6167

* Thanks Semantic-Org#5902

* Implements Semantic-Org#4458

* Thanks Semantic-Org#4614

* Thanks Semantic-Org#4614

* Revert "'on: change' causes error prompts to appear when blurring field "

* Semantic-Org#4423 in next

* Semantic-Org#4423 Thx

* Thanks Semantic-Org#4631

* Semantic-Org#3396 modal close

* Fix transitions on ui images > .image

* Adds glow transition

* Input selectors now require child selector to avoid inheritance issues Semantic-Org#4157

* rlsnotes

* Fix eventNamespace in Semantic-Org#3396

* Fix modal flex issue in IE11

* Add zoom transition

* Add mobile styles for search

* Add PR links to rlsnotes

* Rlsnotes Semantic-Org#6167

* Semantic-Org#5892 - Add onChanging callback

* Tighten scrolling margin

* Build 2.3.0

* Update README.md

Remove forum from readme

* Update README.md

* Update README.md

Remove project talk

* Update README.md

* Update README.md

* Update README.md

* Update RELEASE-NOTES.md

* Create stale.yml

* chore(stale.yml): update exempt labels

* Add issue templates

* Update ISSUE_TEMPLATE.md

* Update ISSUE_TEMPLATE.md

* Update ISSUE_TEMPLATE.md

* Update ISSUE_TEMPLATE.md

* Update ISSUE_TEMPLATE.md

* Update ISSUE_TEMPLATE.md
@chaseholdren
Copy link

Would someone mind adding the version constraint to the gulp-clone peer dependency as well?

@coffeeowl
Copy link

in a desperate attempt to build another theme I forked the whole repo, set gulp-clone to 1.1.3 and still no css files...

@j-cong
Copy link

j-cong commented Oct 14, 2018

@jlukic Looks like this problem is back, as "gulp-clone": "^2.0.1", was updated. Shouldn't this issue be reopened?

@rsbepvb
Copy link

rsbepvb commented Oct 16, 2018

Having the same problem.

@Coteh
Copy link

Coteh commented Oct 17, 2018

Was just having the same issue as well, and the change applied in himanshu230's PR (#6631) fixes the problem for me.

@dankythuat
Copy link

Was just having the same issue as well, and the change applied in himanshu230's PR (#6631) fixes the problem for me.

yep, me too,

@dankythuat
Copy link

How to import semantic.min.js i get error at line 11.
after that, i install jquery and import in index.js but nothing works
import * as $ from "jquery"
import "./semantic/dist/semantic.min.js"

@bugproof
Copy link

this issue should be re-opened

@riez
Copy link

riez commented Oct 20, 2018

yeah i got same problem, its doesnt build semantic.min.css

@jlukic
Copy link
Member

jlukic commented Oct 21, 2018

Fixed in 2.4.2 patch

@seunoyebode
Copy link

I have the same problem "gulp build" doesn't build semantic.min.css and semantic.min.js

@y0hami
Copy link
Member

y0hami commented Jan 18, 2019

@seunoyebode Please provide some more info like node, npm and SUI version.

@seunoyebode
Copy link

@hammy2899 Node v8.11.4 npm 5.8.0 gulp CLI version 2.0.1 local version 3.9.1

@y0hami
Copy link
Member

y0hami commented Jan 18, 2019

@seunoyebode Is this a new installation or an old instance?

The following worked for me

$ node -v && npm -v
v8.11.4
5.6.0
$ mkdir sui-test && cd sui-test
$ npm init -y
$ npm install --save semantic-ui
$ cd semantic
$ npx gulp build

Try running the commands above in a separate directory and see if that works.

@seunoyebode
Copy link

Thanks @hammy2899 That worked. Although i had to install npx. It's working now.

By the way i think the getting started guide should be more explicit @jlukic

Thanks you guys are doing a great job. I'm ditching Bootstrap!!!

@y0hami
Copy link
Member

y0hami commented Jan 18, 2019

@seunoyebode good to hear 🙂

Note: npx comes installed by default with [email protected] or greater

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests