[Modal] Fullscreen modal stuck to left edge of page

[GammaGames]

Steps

1. Create a fullscreen modal in html
2. Call the modal function on it and show

Expected Result

Modal should be centered

Actual Result

Modal is stuck to left edge of page

Version

2.4.0

Testcase

https://jsfiddle.net/Ljcyd5ek/

It can be fixed by adding the following css into the page to override it:

.ui.fullscreen.modal {
  left: 2.5% !important;
}

[pfcodes]

+1

[pfcodes]

@GammaGames The CSS to override isn't working for me. I'm using the SUI CSS only version and even tried editing the source stylesheet file to no avail. Any other quick dirty fix?

Edit: I resolved my issue with .ui.fullscreen.scrolling.modal

[GammaGames]

Yeah, the .ui.fullscreen.scrolling.modal was more specific, so it was overriding the base .ui.fullscreen.modal rules. If you want to read more, here's a short explanation.

Also, in the future just add a thumb to the thread instead of a +1 comment. Everyone subscribed (with this thread it's not many) gets a notification whenever someone comments, and GitHub has tools to sort by the most reactions to see which issues have the most support.

[jlukic]

I'll fix this.

[jlukic]

I've fixed this for patch today

No left offset is necessary with flex or legacy modals. With legacy it will be calculated in javascript. In flex, it's handled with flex container.

[SaphuA]

@jlukic

This does not appear to be fixed in v2.4.2??

See -> https://codepen.io/anon/pen/aPJLya