-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FontAwesome #6395
Comments
I am currently in the process of doing this. |
Can you link the fixes when you got a chance? Would love to use it in my project. |
In the meantime, FA 5.1 is out. It would be greatly appreciated if this version is added too :) |
Sorry it took me so long but I have finished the icon generation script and have made a repo for it https://github.com/hammy2899/fomantic-ui-icon-script. It can be used for FontAwesome free or pro. I will also be added FontAwesome 5.2.0 to Fomantic in 2.5, you can keep up to date here fomantic/Fomantic-UI#79 |
Will this be also integrated in semantic-ui? |
@Flipez I will try and get some time to do it today |
Thank you! If the workflow for updating font awesome would be more clear I'd like to contribute aswell. |
This may take me a little longer because I will need to solve some conflicts and I need to make some adjustments to the docs. |
Has this been put on the roadmap? This is the file that needs to be updated (along with the actual icon assets), right? https://github.com/Semantic-Org/Semantic-UI/blob/master/src/themes/default/elements/icon.overrides |
I decided to create a monkey patch for this. Useful to stop the prop types warning messages for legit font awesome icons in development while providing suggestions in case you mess up. Feel free to take a look if anyone needs this. |
I just created this issue, related to the same thing. |
Currently FontAwesome 5.0.8 is implemented but since then they introduced a lot new icons.
The latest version is currently 5.0.13 (https://github.com/FortAwesome/Font-Awesome/blob/master/CHANGELOG.md)
Would be nice to see this in a new semantic release.
The text was updated successfully, but these errors were encountered: