-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Font Awesome icons to v.5.9 #3724
Comments
👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. |
This is only the react implementation of semantic ui. The css comes from the mainline repo. There’s an issue there tracking the upgrade. |
@fracmak @layershifter First, thanks for all that you do for this project - it truly is great. It's not worth reopening the debate on whether or not SUI is dead or not, but I think it's safe to say that the chances SUI imports the v5.9 package anytime soon is unlikely. Given that, do you have any recommendations for how someone using SUIR can consume new font awesome icons? I see a few options:
I'm not in love with either of those options. Just wanted to check here to see if you had a better suggestion on how to make this happen. |
I've had success in adding new icons using something like icomoon where I can import the existing fonts, add extra ones, then adding them to a sui theme project under specific names. While it's not ideal cause I can't reference the icons using Icon name attribute, nothing stops me from adding classNames for the new names. It's not ideal, but it does work. |
Feature Request
Problem description
There are many new icons that would be nice to use with Semantic UI React.
Proposed solution
Import the latest 5.9 icons
The text was updated successfully, but these errors were encountered: