Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Font Awesome icons to v.5.9 #3724

Closed
snydercoder opened this issue Jul 28, 2019 · 4 comments
Closed

Update Font Awesome icons to v.5.9 #3724

snydercoder opened this issue Jul 28, 2019 · 4 comments
Labels

Comments

@snydercoder
Copy link

Feature Request

Problem description

There are many new icons that would be nice to use with Semantic UI React.

Proposed solution

Import the latest 5.9 icons

@welcome
Copy link

welcome bot commented Jul 28, 2019

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

@fracmak
Copy link
Member

fracmak commented Jul 28, 2019

This is only the react implementation of semantic ui. The css comes from the mainline repo. There’s an issue there tracking the upgrade.

Semantic-Org/Semantic-UI#6395

@fracmak fracmak closed this as completed Jul 28, 2019
@lafritay
Copy link
Contributor

@fracmak @layershifter First, thanks for all that you do for this project - it truly is great.

It's not worth reopening the debate on whether or not SUI is dead or not, but I think it's safe to say that the chances SUI imports the v5.9 package anytime soon is unlikely. Given that, do you have any recommendations for how someone using SUIR can consume new font awesome icons?

I see a few options:

  1. Fork SUI and update the package. Fork SUIR (at least the typescript types to define the new icons).
  2. Swap in the css from fomantic-ui (even though this isn't supported). Fork SUIR (at least the typescript types to define the new icons).

I'm not in love with either of those options. Just wanted to check here to see if you had a better suggestion on how to make this happen.

@fracmak
Copy link
Member

fracmak commented Sep 12, 2019

I've had success in adding new icons using something like icomoon where I can import the existing fonts, add extra ones, then adding them to a sui theme project under specific names. While it's not ideal cause I can't reference the icons using Icon name attribute, nothing stops me from adding classNames for the new names. It's not ideal, but it does work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants