Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"link" icon is displayed instead of the correct icon #6180

Closed
Baloche opened this issue Feb 20, 2018 · 3 comments
Closed

"link" icon is displayed instead of the correct icon #6180

Baloche opened this issue Feb 20, 2018 · 3 comments
Labels
Confirmed Bug High Priority
Milestone
2.3.1

Comments

@Baloche
Copy link

Baloche commented Feb 20, 2018

I just updated Semantic UI, and I noticed that for some icons, when I want a link behaviour on my icon, I instead get the "link" icon.

<!-- Here, "link" icon is displayed instead of "retweet" icon -->
<i class="retweet link icon"></i>

I believe this is due to the "link" style definition overriding every previous single-named icon definition.
@Baloche
Copy link
Author

Baloche commented Feb 20, 2018 •
edited
Loading

Either the name of the "link" icon or the name of the "link" behaviour (pointer + opacity change on hover) has to change.

y0hami pushed a commit to y0hami/Semantic-UI that referenced this issue Feb 20, 2018
Fixed exchange.alternate icon Fixes Semantic-Org#6175
dbe840a 
Fixed arrows.alternate.horizontal
Fixed arrows.alternate.vertical
Fixed arrow.alternate.circle.*
Fixed user.circle.outline Fixes Semantic-Org#6176
Removed link and left linkify icon Fixes Semantic-Org#6180
Bumped envelope unicode to stop conflict with resize.vertical
@y0hami y0hami mentioned this issue Feb 20, 2018
Merged
@y0hami y0hami added this to the 2.3.1 milestone Feb 24, 2018
exoego pushed a commit to exoego/Semantic-UI that referenced this issue Feb 25, 2018
Fixed exchange.alternate icon Fixes Semantic-Org#6175
e1ebcf2 
Fixed arrows.alternate.horizontal
Fixed arrows.alternate.vertical
Fixed arrow.alternate.circle.*
Fixed user.circle.outline Fixes Semantic-Org#6176
Removed link and left linkify icon Fixes Semantic-Org#6180
Bumped envelope unicode to stop conflict with resize.vertical
@jlukic
Copy link
Member

jlukic commented Feb 28, 2018 •
edited
Loading

There shouldnt be an icon named link it should be linkify this is no good.

@y0hami y0hami mentioned this issue Mar 16, 2018
Closed
@jlukic
Copy link
Member

jlukic commented Mar 19, 2018

This is fixed in next.

@jlukic jlukic closed this as completed Mar 19, 2018
@brownspy1 brownspy1 mentioned this issue Jun 29, 2024
Merged
@BLACK-NINJA-PK BLACK-NINJA-PK mentioned this issue Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Confirmed Bug High Priority
Projects
None yet
Milestone
2.3.1
Development

No branches or pull requests
3 participants
@jlukic @Baloche @y0hami