Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown] Selected multiple options are hidden (2.2.14) #6123

Closed
Thanty opened this issue Jan 29, 2018 · 22 comments
Closed

[Dropdown] Selected multiple options are hidden (2.2.14) #6123

Thanty opened this issue Jan 29, 2018 · 22 comments

Comments

@Thanty
Copy link

Thanty commented Jan 29, 2018

I've used to generate dropdowns from HTML in my forms, but Semantic 2.2.14 has a critical bug: selected options are hidden (but they are still considered as selected if you submit a form):

https://jsfiddle.net/3LaahL7e/1/

@Thanty Thanty changed the title [Dropdown] Selected multiple options are hidden [Dropdown] Selected multiple options are hidden (2.2.14) Jan 30, 2018
@harrisnl
Copy link

harrisnl commented Jan 30, 2018

I just noticed this same bug, seems to be javascript related.
When using the old 2.2.13 library, the options are visible again.

@prudho
Copy link

prudho commented Jan 30, 2018

Seem to be introduced by 0fa5821.

@iROCKBUNNY
Copy link

I am suffering from this issue. This bug seems critical and needs a hot fix.

@adas172002
Copy link

+1

@jbwl
Copy link

jbwl commented Feb 2, 2018

I think I have the same symptom after upgrading to 2.2.14: Selected options (stored in the input tag's value attribute) are not displayed as preselected in the input field anymore. The input field appears empty.

@jamesdb
Copy link

jamesdb commented Feb 5, 2018

+1

@StevenBaby
Copy link

+1

@camueller
Copy link

I noticed this problem as well. After downgrading to 2.2.12 pre-selected options are displayed properly!

camueller added a commit to camueller/SmartApplianceEnabler that referenced this issue Feb 11, 2018
@kjo6152
Copy link

kjo6152 commented Feb 19, 2018

I create pull request for this issue. #6169

@Thanty
Copy link
Author

Thanty commented Feb 20, 2018

Semantic-Org, thanks for the new 2.3.0 release! There are really good enhancements and features, but we still cannot upgrade because of this one... Have to use 2.2.13.

@iROCKBUNNY
Copy link

Are there any other possible work-arounds or tricks? What about some tweaks on the dropdown JS components when initializing them?

@iROCKBUNNY
Copy link

iROCKBUNNY commented Feb 20, 2018

@hammy2899 could you help label this bug? This looks quite critical. Thanks a lot!

@thejhnz
Copy link

thejhnz commented Feb 27, 2018

+1

@jlukic jlukic added this to the 2.3.1 milestone Feb 28, 2018
@jlukic
Copy link
Member

jlukic commented Feb 28, 2018

Will address in next patch.

@iROCKBUNNY
Copy link

@jlukic Excited!

@bianjp
Copy link

bianjp commented Mar 6, 2018

Just met the same problem, and found that it was caused by the change from if(module.has.label(value)) to if(module.has.value(value)) introduced in 0fa5821. Reverting this line is enough to fix it. But I'm not sure why it's introduced and whether reverting is appropriate or not.

Anyway, I hope that 2.3.1 can come soon.

@arturamaj
Copy link

+1

@jlukic
Copy link
Member

jlukic commented Mar 14, 2018

I'll have time to address this issue, this sunday. Thanks for your patience.

@jlukic
Copy link
Member

jlukic commented Mar 18, 2018

This should be fixed in 0e5c824, with a tiny change.

Labels were checking if the dropdown value already was set (for dupe matching) but because of the order of operations with initializing multi selects from <select> this would always prevent labels from being drawn.

@jlukic
Copy link
Member

jlukic commented Mar 19, 2018

This is fixed in 2.3.1 releasing tonight

@subramn
Copy link

subramn commented Sep 1, 2018

I am also running into this problem, my pre-selected options are not showing. any workaround available

@jbwl
Copy link

jbwl commented Sep 4, 2018

subramn - it has been fixed in 2.3.1

#6123 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests