Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm WARN "deprecated gulp-minify-css" on semantic-ui 2.2.3 #4463

Closed
designosis opened this issue Aug 22, 2016 · 2 comments
Closed

npm WARN "deprecated gulp-minify-css" on semantic-ui 2.2.3 #4463

designosis opened this issue Aug 22, 2016 · 2 comments
Labels
Confirmed Bug
Milestone
2.2.4

Comments

@designosis
Copy link

When doing an npm update, semantic went from 2.2.2 to 2.2.3, and this error appeared:

UNMET PEER DEPENDENCY gulp-minify-css@*
npm WARN [email protected] requires a peer of gulp-minify-css@* but none was installed.
npm WARN deprecated [email protected]: Please use gulp-clean-css

Solved with a simple npm install gulp-minify-css --save-dev, of course, but you know, when npm says an unmet peer is deprecated, I get a bit queasy and gassy ;)
@jlukic
Copy link
Member

jlukic commented Aug 22, 2016

minify-css is no longer being used. We've updated to clean-css in 2.2.3 unfortunately forgot to wipe it from the package.json will remove in next bump.

@jlukic jlukic added this to the 2.2.4 milestone Aug 22, 2016
@jlukic jlukic removed this from the 2.2.5 milestone Aug 25, 2016
@jlukic
Copy link
Member

jlukic commented Aug 25, 2016

Fixed in 2.2.4

@jlukic jlukic closed this as completed Aug 25, 2016
jlukic added a commit that referenced this issue Aug 25, 2016
@jlukic
#4463 - remove bad dep
190e8e5
@jlukic jlukic added this to the 2.2.4 milestone Aug 25, 2016
ali1k added a commit to slidewiki/custom-semantic-ui that referenced this issue Oct 14, 2016
@ali1k
Merge branch 'master' of https://github.com/Semantic-Org/Semantic-UI
81d9442 
* 'master' of https://github.com/Semantic-Org/Semantic-UI: (62 commits)
  Fix fg-color on inverted forms in Flat theme.
  Add transition fallback to progress
  Rebuild 2.2.4
  Semantic-Org#4463 - remove bad dep
  Build 2.2.4
  Fixes missing message var
  Revert "zone.js/issues/319 Loosen equality on undefined check for determining input event"
  Fix typos in rlsnotes 2.2.3
  Finalize release notes 2.2.3
  Build 2.2.3
  Semantic-Org#4284 - Fixes obvious brand colors.. tbd instagram
  Add iconPath duplication to avoid reqing material site theme
  Semantic-Org#4412, redo paths to be more consistent with default theme
  Rlsnotes Semantic-Org#4399
  Semantic-Org#4403 cred
  Semantic-Org#4408 - adds cred
  Fixes comment sizing Semantic-Org#4408
  Fix point-events typo Semantic-Org#4408
  Update icon.variables
  Corrected for missing <i> selector
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Confirmed Bug
Projects
None yet
Milestone
2.2.4
Development

No branches or pull requests
2 participants
@jlukic @designosis