Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Television Icon #4178

Closed
EQuimper opened this issue Jun 27, 2016 · 7 comments
Closed

Television Icon #4178

EQuimper opened this issue Jun 27, 2016 · 7 comments
Milestone

Comments

@EQuimper
Copy link

Hey, I would like to know what happen with the television icon. I find it into your doc but this is a blank icon.

@jlukic jlukic added this to the 2.2.2 milestone Jun 28, 2016
@jlukic
Copy link
Member

jlukic commented Jun 28, 2016

Looks like it has disappeared. Time to investigate

@xaeroseven
Copy link

I noticed this as well. It looks like 'tv icon' works in the meantime @EQuimper.

@EQuimper
Copy link
Author

@xaeroseven tv icon don't work for me.

@xaeroseven
Copy link

@EQuimper here is a fiddle I made from the boilerplate fork example: http://jsfiddle.net/1bemvetf/, it's using 2.2.1 and tv icon looks to be working in my fiddle at least. I haven't tried upgrading our Semantic 2.1.8 project yet to 2.2.1 so there might be an issue once I have everything built. Sorry for the mislead on it

@awei01
Copy link

awei01 commented Jul 30, 2016

I'm haven't dug into the css generation code, but I suspect there's an issue with the less files. Looking at semantic-ui-css generated code, this is the result for grab and television icons. Notice the :before is missing after grab and television. Hopefully this will help someone track down the error in the less files.

i.icon.grab {
  content: "\f255";
}
i.icon.hand.victory:before {
  content: "\f25b";
}

/* truncated */

i.icon.television {
  content: "\f26c";
}

@jlukic
Copy link
Member

jlukic commented Jul 31, 2016

Thanks @awei01 that helped a bit narrowing it down.

@jlukic jlukic closed this as completed Jul 31, 2016
@awei01
Copy link

awei01 commented Aug 1, 2016

@jlukic sure, np.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants