Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] onSelect return false does not prevent closing results #3870

Closed
tomazzlender opened this issue Mar 25, 2016 · 3 comments
Closed

[Search] onSelect return false does not prevent closing results #3870

tomazzlender opened this issue Mar 25, 2016 · 3 comments

Comments

@tomazzlender
Copy link

It looks like setting return false to onSelect callback does not prevent closing results popup in the latest version 2.1.8.

In previous version it worked like you can see in the following fiddle
http://jsfiddle.net/vw35s0un/

But not with the latest version
http://jsfiddle.net/joqtdzan/1/

  1. In both cases type something in the input field like "a"
  2. Click on result.

In first fiddle (old semantic ui version) it closes in another (newest semantic ui version) it does not.

What should I do to prevent closing results popup when something is clicked inside popup?

@jlukic jlukic added this to the 2.1.9 milestone Apr 22, 2016
@jlukic
Copy link
Member

jlukic commented Apr 22, 2016

I'm not sure the best way to handle this, both cases make sense to me.

@jlukic jlukic modified the milestones: 2.1.9, 2.2 May 4, 2016
@jlukic
Copy link
Member

jlukic commented May 4, 2016

Merged into #3856

jlukic added a commit that referenced this issue May 15, 2016
@jlukic
Copy link
Member

jlukic commented May 15, 2016

Fix in #3856

@jlukic jlukic closed this as completed May 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants