Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Checkbox] onEnabled/onDisabled setting misspelled or regressed #3761

Closed
petruavram opened this issue Feb 26, 2016 · 2 comments
Closed

[Checkbox] onEnabled/onDisabled setting misspelled or regressed #3761

petruavram opened this issue Feb 26, 2016 · 2 comments
Labels
Confirmed Bug
Milestone
2.2

Comments

@petruavram
Copy link

I managed to track down the cause of the bug. It is a regression that was introduced by fixing #3148. I don't think it's possible to fix this and avoid the backwards incompatibility unless both forms of the methods are defined as settings and called inside enable.

Reproduced bug jsFiddle
@petruavram petruavram changed the title Checkbox onEnabled setting misspelled or regressed Checkbox onEnabled/onDisabled setting misspelled or regressed Feb 26, 2016
petruavram pushed a commit to petruavram/Semantic-UI that referenced this issue Feb 26, 2016
Fixes Semantic-Org#3761 issue with misspelled callbacks
6e56420
@petruavram petruavram mentioned this issue Feb 26, 2016
Closed
@jlukic jlukic added this to the 2.1.9 milestone Mar 6, 2016
@jlukic
Copy link
Member

jlukic commented Mar 6, 2016

Thanks for the ping, I'll take a look

@petruavram petruavram changed the title Checkbox onEnabled/onDisabled setting misspelled or regressed [Checkbox] onEnabled/onDisabled setting misspelled or regressed Apr 26, 2016
@jlukic jlukic modified the milestones: 2.1.9, 2.2 May 4, 2016
@jlukic
Copy link
Member

jlukic commented May 15, 2016 •
edited
Loading

Added both callbacks until 3.0 to avoid issues. Typos suck for backwards compatibility..
ed98c55

@jlukic jlukic closed this as completed May 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Confirmed Bug
Projects
None yet
Milestone
2.2
Development

No branches or pull requests
2 participants
@jlukic @petruavram