Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popup] Add onUnplaceable callback, Fix Docs Description of Errors #3388

Closed
tmikaeld opened this issue Nov 25, 2015 · 5 comments
Closed

[Popup] Add onUnplaceable callback, Fix Docs Description of Errors #3388

tmikaeld opened this issue Nov 25, 2015 · 5 comments

Comments

@tmikaeld
Copy link

The docs don't reflect the settings in popup.js

Should be:

  error: {
    invalidPosition : 'The position you specified is not a valid position',
    cannotPlace     : 'Popup does not fit within the boundaries of the viewport',
    method          : 'The method you called is not defined.',
    noTransition    : 'This module requires ui transitions <https://github.com/Semantic-Org/UI-Transition>',
    notFound        : 'The target or popup you specified does not exist on the page'
  },

Not:

error: {
  content   : 'Your popup has no content specified',
  method    : 'The method you called is not defined.',
  recursion : 'Popup attempted to reposition element to fit, but could not find an adequate position.'
}
@jlukic
Copy link
Member

jlukic commented Nov 28, 2015

Thanks missed copy and paste.

@jlukic jlukic added this to the 2.1.7 milestone Nov 28, 2015
@tmikaeld
Copy link
Author

Is it possible to get a callback when the popup doesn't fit? When using it in admin interfaces it would be good to be able to inform the user to increase their browser height to fit an editing box.

@jlukic
Copy link
Member

jlukic commented Nov 30, 2015

I agree that makes sense as well.

@jlukic jlukic changed the title Popup docs debug error messages are old. [Popup] Add onUnplaceable callback, Fix Docs Description of Errors Nov 30, 2015
@jlukic
Copy link
Member

jlukic commented Nov 30, 2015

Added. Deving on an offline VM but tagged commit will follow.

@tmikaeld
Copy link
Author

tmikaeld commented Dec 1, 2015

Thinking more about this, it would make sense to have an additional position instead of displaying in a modular window. "Center Center" - position the popup in the center of the element. Your thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants