Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dropdown tabindex #3002

Closed
mohsensafari opened this issue Sep 11, 2015 · 7 comments
Closed

dropdown tabindex #3002

mohsensafari opened this issue Sep 11, 2015 · 7 comments
Labels
Confirmed Bug
Milestone
2.1.5

Comments

@mohsensafari
Copy link

Hi, I think there is a bug on dropdown tabindex functionality. if dropdown has not got a "search" class the semantic dropdown module give it a tabindex of "-1" in remove:tabbable function and then it never change on set:tabbable with a tabindex of "-1" the tab ordering of modules not work properly
@jlukic
Copy link
Member

jlukic commented Sep 11, 2015

Please fork the JSFiddle in the readme to create a test case.

@NeverI
Copy link

NeverI commented Sep 24, 2015

Here is the JSFiddle http://jsfiddle.net/xs81ghub/1/

@jlukic jlukic added this to the 2.1.5 milestone Sep 25, 2015
@jlukic
Copy link
Member

jlukic commented Sep 25, 2015

Thanks neverl for picking this up.

@RobinKuiper
Copy link

It's getting tabindex='0' all the time for me, any news on this?

jlukic added a commit that referenced this issue Nov 1, 2015
@jlukic
#3002, fixes tab index broken on selection dropdown
d85ce6e
@jlukic
Copy link
Member

jlukic commented Nov 1, 2015

Thanks for your patience here.

jlukic added a commit that referenced this issue Nov 1, 2015
@jlukic
#3002, fixes tab index broken on selection dropdown
77954a2
@RobinKuiper
Copy link

Awesome!

@jlukic jlukic modified the milestones: 2.1.5, 2.1.7 Nov 6, 2015
@jlukic
Copy link
Member

jlukic commented Nov 30, 2015

Should have been fixed in 2.1.5, this bug was mistagged.

@jlukic jlukic modified the milestones: 2.1.5, 2.1.7 Nov 30, 2015
@jlukic jlukic closed this as completed Nov 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Confirmed Bug
Projects
None yet
Milestone
2.1.5
Development

No branches or pull requests
4 participants
@jlukic @NeverI @RobinKuiper @mohsensafari