Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Trim function does not exist in IE 10-11 #2806

Closed
TheSlider2 opened this issue Aug 7, 2015 · 2 comments
Closed

[Modules] Trim function does not exist in IE 10-11 #2806

TheSlider2 opened this issue Aug 7, 2015 · 2 comments
Milestone

Comments

@TheSlider2
Copy link

Greetings,

I have an issue where IE 10-11 messes up my sexy admin tools.
I get an error about trim not being a valid function so i replaced it with "replace(/^\s+|\s+$/g, '')"

Error was reported on line 4246 ( semantic.js v1.12.3 )
real lines were 4249 and 4250

? $choice.html().trim()
: $choice.text().trim()

becomes

? $choice.html().replace(/^\s+|\s+$/g, '')
: $choice.text().replace(/^\s+|\s+$/g, '')

Didn't test much but no more errors + working tools = good enough.

I'll check if this was updated on 2.0 when i'll be upgrading next week.

Cheers

@jlukic jlukic added this to the 2.1 milestone Aug 7, 2015
@jlukic
Copy link
Member

jlukic commented Aug 7, 2015

Easy enough

@jlukic jlukic changed the title trim function does not exist in IE 10-11 [Modules] Trim function does not exist in IE 10-11 Aug 11, 2015
jlukic added a commit that referenced this issue Aug 11, 2015
@jlukic
Copy link
Member

jlukic commented Aug 11, 2015

Sorry about delays here, in next.

@jlukic jlukic closed this as completed Aug 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants