Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popup] .popup('is visible') initially returns DOM element #2781

Closed
hpohl opened this issue Aug 4, 2015 · 2 comments
Closed

[Popup] .popup('is visible') initially returns DOM element #2781

hpohl opened this issue Aug 4, 2015 · 2 comments
Milestone

Comments

@hpohl
Copy link

hpohl commented Aug 4, 2015

http://jsfiddle.net/yzjop769/1/

When the popup never has been opened, the target element is returned instead of false.

@jlukic jlukic added this to the 2.1.x milestone Aug 5, 2015
@homerjonathan
Copy link

Seems there is the same issue with sidebar. When calling "is visible" and it has not been toggled then it too returns the target element.

@jlukic jlukic modified the milestones: 2.1.7, 2.1.x Nov 6, 2015
@jlukic
Copy link
Member

jlukic commented Dec 19, 2015

@hpohl @homerjonathan

Thanks for your patience here. is visible was returning undefined in the case where $popup was undefined. This was making the invocation fail and revert to chaining instead of returning the result.

I've modified the booelan to correctly return false.

I don't believe sidebar suffers from the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants