Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tab/API] Tabs Should Not Encode Params, API should add setting encodeParameters #2752

Closed
BigGrecian opened this issue Jul 31, 2015 · 2 comments

Comments

@BigGrecian
Copy link

I am using ajax tabs to open up a customer's details and as such when the page is sent to the browser the tab url looks like so :

 <a class="active item" data-tab="profile.php?student=2027">Basic Profile</a> 

    <div class="ui bottom attached active tab segment" data-tab="profile.php?student=2027">

    </div>


However on upgrade to 2.0.7 the URL gets encoded as
./useredit/profile.php%3Fstudent%3D2027

which obviously returns a 404 code as it expects?
.useredit/profile.php?student=2027

As below :

image

This used to work fine in 2.0.3 and before

Any idea how to rectify this?

@jlukic
Copy link
Member

jlukic commented Jul 31, 2015

#2394 urlData is now urlEncoded by default.

I can understand why this would cause issues particularly with data-tab which sometimes will include the query string as part of the parameter.

It was a mistake not to include a setting to disable this. I'll add an apiSetting encodeData and make it false by default for tab.

@jlukic jlukic added this to the 2.1 milestone Jul 31, 2015
@jlukic jlukic changed the title Tabs in 2.0.7 [Tab] Tabs Should Not Encode Params Aug 3, 2015
@jlukic jlukic changed the title [Tab] Tabs Should Not Encode Params [Tab/API] Tabs Should Not Encode Params, API should add setting encodeParameters Aug 3, 2015
@jlukic
Copy link
Member

jlukic commented Aug 11, 2015

Fixed in 2.1

@jlukic jlukic closed this as completed Aug 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants