Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Grid] Add Reverse Variations #2685

Closed
dalgard opened this issue Jul 21, 2015 · 6 comments
Closed

[Grid] Add Reverse Variations #2685

dalgard opened this issue Jul 21, 2015 · 6 comments
Milestone

Comments

@dalgard
Copy link

dalgard commented Jul 21, 2015

In version 1.x, I could make the first column in a grid right floated in order to pull the next column up on its left side. This way, when the columns stack on mobile, I could make the content to the right show first on the scroll.

Did this feature disappear out of thin air? Most of the layouts on my site depend on it.

@dalgard
Copy link
Author

dalgard commented Jul 21, 2015

Adding a set of classes to change flex properties, such as flow direction, might be a good way to go.

@jlukic
Copy link
Member

jlukic commented Jul 21, 2015

You can use right floated and left floated still however they should appear in normal flow order. right floated needs to be last.

See docs
www.semantic-ui.com/collections/grid.html#floated

@dalgard
Copy link
Author

dalgard commented Jul 21, 2015

This is exactly the problem that I'm pointing out.

@jlukic
Copy link
Member

jlukic commented Jul 21, 2015

This is just how floating works in flex it uses margin-left: auto.

I could see a variation to reverse flex direction per device. i.e. class name reverse mobile = flex-direction: column-reverse; , but this is not the same as floating.

You can also do this in one line in css, which is not necessarily a bad alternative.

@dalgard
Copy link
Author

dalgard commented Jul 31, 2015

I figured out the column-reverse property – it's a good solution, and I definitely think you should add a class for it. For the time being, I've added it as an override.

@jlukic jlukic changed the title What happened to floating columns for better stacking order? [Grid] Add Reverse Variations Jul 31, 2015
@jlukic jlukic reopened this Aug 13, 2015
@jlukic
Copy link
Member

jlukic commented Aug 13, 2015

Implemented in 2.1 as reversed tablet, reversed mobile etc

jlukic added a commit that referenced this issue Aug 13, 2015
@jlukic jlukic added this to the 2.1 milestone Aug 13, 2015
jlukic added a commit that referenced this issue Aug 14, 2015
jlukic added a commit that referenced this issue Aug 14, 2015
@jlukic jlukic closed this as completed Aug 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants