Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Checkbox] toggle don't have the "checked" class when initialized in a 'checked' state #2506

Open
deneuxa opened this issue Jul 2, 2015 · 8 comments

Comments

@deneuxa
Copy link
Contributor

deneuxa commented Jul 2, 2015

you can see this in the doc :

capture d ecran 2015-07-02 a 22 19 39

when initializing the page the first slider is checked, but don't have the "checked" class.

capture d ecran 2015-07-02 a 22 19 55

If you click on the second one, and then click on the first one (to get it back to his checked status), then it has correctly its 'checkec' class

capture d ecran 2015-07-02 a 22 20 07

@deneuxa
Copy link
Contributor Author

deneuxa commented Jul 2, 2015

and bye the way :)

Release note 2.0 :
capture d ecran 2015-07-02 a 22 32 28

Doc :
capture d ecran 2015-07-02 a 22 32 16

This is still a bug right ?
Even if the callback isn't fired, the "checked" class should be added, right ?

@jlukic jlukic added this to the 2.0.x milestone Jul 2, 2015
jlukic added a commit that referenced this issue Jul 6, 2015
@jlukic
Copy link
Member

jlukic commented Jul 6, 2015

Hi, this was caused by module.get.radios() being used to uncheck other radios. This group unfortunately includes the just activated checkbox. Causing it to immediately uncheck itself.

Will be fixed in 2.0.1

@deneuxa
Copy link
Contributor Author

deneuxa commented Jul 6, 2015

Thanks !

it fixed the problem in my current project too :)

2015-07-06 20:20 GMT+02:00 Jack Lukic [email protected]:

Closed #2506 #2506.


Reply to this email directly or view it on GitHub
#2506 (comment).

@awgv awgv modified the milestones: 2.0.1, Needs Milestone Nov 6, 2017
@awgv awgv changed the title toggle don't have the "checked" class when initialized in a 'checked' state [Checkbox] toggle don't have the "checked" class when initialized in a 'checked' state Nov 6, 2017
@awgv
Copy link
Member

awgv commented Nov 6, 2017

This is an issue again.

@zerolfc
Copy link

zerolfc commented Nov 21, 2017

This is still happening. thought was fixed in 2.0.1

@stale
Copy link

stale bot commented Jun 5, 2018

There has been no activity in this thread for 90 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 90 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

@stale stale bot added the stale label Jun 5, 2018
@ghost
Copy link

ghost commented Jul 31, 2018

This is still a problem in 2.3. Surely this is an easy fix, @jlukic?

@lubber-de

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants
@jlukic @deneuxa @zerolfc @awgv @lubber-de and others