-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] Add Quiet Option #1816
Comments
It probably wouldnt be too difficult to add since build scripts have config data available. Would just require modifying Will brainstorm on this |
seconded ! i also note that installing semantic-ui now pulls shitloads of gulp modules - this is not so friendly, as not everybody is keen using gulp. |
Based on my initial testing, it looks like npm config variables do not cascade, so this may not be an option :/ Is there a reason why semantic-ui runs gulp install automatically? Users of the gulp build system would probably be alright with taking the extra step to run gulp install themselves...do you agree? |
@kapouer I will be creating separate repos/distributions for LESS/JS only and CSS/JS only, these will shadow the main repo and reduce file size for those who want to roll their own build system. @mendenhallmagic The issue is they'd have to run |
It's worth noting that if theres a |
@jlukic thank you for the semantic-ui-css and al. repos ! great ! |
I think having a |
Currently, it seems that not only the semantic.json in project root is required, but also the entire custom build system (projectroot/semantic by default) is the minimum required structure to run "npm install semantic-ui" without user interaction. I would consider this less than ideal... However, I jumped on over to using semantic-ui-less, which doesn't have these requirements. Thanks for this! FWIW, we can close this issue, but I would like to bring up a related issue. Let me know if I should open up another issue to begin this discussion: My current workflow is still less than ideal, coming from using bootstrap, whose project's goals/philosophy are admittedly different (e.g. the standard one scope of variables). I'm still in the camp that prefers to import one less file from npm/bower, import local variables and rules file(s) for customization. My current build process still has a few too many steps, IMO:
It might be worth noting that I share *.variables between my project's less structure and semantic's, so that I can use the base font size, etc. in my project's less structure, which is a big reason for even building semantic in less in the first place, second to powerful customization of semantic itself. I would consider the ideal workflow to have the package already have 1 & 2 done for the consumer of the framework, as it seems like a reasonable default to me. If the user wants to customize or use different themes, then either perform the workflow above on semantic-ui-less, or, perhaps more appropriately, npm install semantic-ui. I'm new to this project, so I don't know if any of this goes against its goals/philosophy...let me know what you think! |
Oops, I misclicked the close button...oh well I might open a new issue regarding a lower barrier to entry (from other less frameworks)...would like to hear/read some initial thoughts you might have though. To make things more concrete, I am asking if it makes sense to have a site (not _site) folder, theme.config, and semantic.less in semantic-ui-less. |
@mendenhallmagic i have a similar workflow but it's a bit simpler because i symlink files from node_modules/semantic-ui-css to the place where the project need them. It makes updates simpler. |
Ah, good idea! I'll look into that. |
It still needs to interactive after adding |
Did you add the |
OK, I see. I need to add |
I'm experiencing problems with this as well, upgrading from version 1.8. In my build process, I copy pre-configured semantic.json and theme.config files into semantic and run gulp build without ever needing to run gulp install as a build step on my CI server. It looks like Taking this line out prevents gulp install from running when installing packages. @jlukic Would you be open to removing this from package.json and have users manually run Many thanks for all the great work! This is a fantastic project. (Also worth noting, I was reading NPM docs and they discourage using install scripts altogether: https://docs.npmjs.com/misc/scripts#note-install-scripts-are-an-antipattern) |
I'll try to give a bit of background this might be a bit verbose. Things were moved to post-install scripts for several reasons talked about previously #1385. PMs like bower and NPM treat their folders like big temp directories, which doesnt work well for projects like ours that have user files. Using The It then looks for the paths specified in your If a If anyone was curious why some packages are listed as |
@jlukic Thanks for the explanation. Managed to get this working exactly as you described. What I was doing was cd'ing into the semantic repo (which I installed in my project using bower) and ran npm install from there. I'll update my build steps. What I'm looking to / continue do is only commit the Thanks for all the hard work! |
Yeah, that sounds alright for The default gulpfile is created in |
Hi, I'm still having issues with this. I don't want to version the whole Thoughts, @jlukic ? |
Hi. I've tried:
I could only test it under Windows 8, tomorrow I'll try on a Mac. Currently in my CI workflow I'm using the aforementioned bash snippet and in my repo I'm only keeping the semantic.json, the theme.config and my overrides. I still haven't tried with the 2.x branch, but the 1.x branch is working flawlessly with that hacky solution. |
I looked to try and check your commit to see if you'd already considered this but couldn't find it. I think that the Like I said, I'll give the changes a go tomorrow and see if I can get it working. Thanks again for all your hard work, it's much appreciated. |
Instead of waiting to get this all in one go, I'm going to launch with current build fixes today as |
So what exactly was the fix for this? I have the same problem; we use Jenkins for automated testing/builds, the prompt needs to be bypassed. Along with this premise, in our case we don't even need the |
@sgarbesi sounds like you might want Still, +1 for this issue. The need for interactivity is blocking my build, because I need to do automated pushes to OpenShift servers. If at all possible, I would really prefer not to commit the entire My preferred flow would be:
|
@ilikebits I didn't realize the JS was bundled in the CSS repo. This works for me. Thanks. |
@sgarbesi Try |
This has been added with |
version: next (commit #cb0c26d)
|
This took my a while to get right .. so here's an example with a working setup, https://github.com/websemantics/pyrocms-cheatsheet Check-out method Also, notice that This seems to work perfectly with Travis, |
A workaround that I learned was piping my keystrokes to npm install:
|
On top of that, ¿it is possible to install semantic-ui without gulp? I already have my asset pipeline (using Laravel-Mix which uses webpack) and I just want the semantic-ui .less and .js files, I will include the files one by one when I need them. I could install semantic-ui-less, but what about the JS files? Any workaround? I find it pretty dirty to install all the gulp plugins when I am not going to use them. Thank you |
…rompt Consider using semantic-ui-less per the 2/26/2015 post by mendenhallmagic here: Semantic-Org/Semantic-UI#1816 On branch docker Changes to be committed: new file: .dockerignore new file: Dockerfile
First, I just wanted to say thanks for this promising new release. Your dedication to this project is amazing and inspiring. I'm really excited to simplify and speed up our build using the new semantic.less file...
I just have one obstacle to upgrading:
My team has a jenkins build process, so running running npm install with a fresh (empty) node_modules directory is a use-case we have to support. Since the new release runs gulp install without a default semantic.json, user interaction seems to be required to advance the process. The way I got around this before was to npm install, copy a default semantic.json from our project root into the node_modules/semantic-ui, copy the semantic-ui/src/_site folder to the semantic-ui/src/site folder, copy site.variables from our project into semantic-ui/src/site/globals, then run gulp build.
Is there currently a way to run npm install without requiring user interaction?
The text was updated successfully, but these errors were encountered: