Skip to content

Commit

Permalink
Fix issue with scrolling modal and allowMultiple #2423
Browse files Browse the repository at this point in the history
  • Loading branch information
jlukic committed Jan 29, 2018
1 parent 3159fa1 commit aa1d36b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion RELEASE-NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@

**Critical Bugs**
- **Form** - Fixes issue where radio checkbox would not return correct value from `get values` **Thanks @tincdev** #5713 #6043
- **Modal** - Fixes issue where an oversized modal would appear behind an existing modal when using `allowMultiple: true` and a second modal that is larger than the sreen height. #2423

**Enhancements**
- **Button** - Youtube's red color now matches their current brand guidelines **Thanks @hammy2899** #6110
- **Flag** - Adds missing flag for England **Thanks @zyzniewski** #5944
- **Reveal** - `ribbon label` can now work with `reveal` #5681

**Bugs**
- **Form** - Fixe
- **Dropdown** - Fixed issue where dropdown could incorrectly open upward and leftward opening when using `context` setting due to an incorrect offset calculation. **Thanks @dannyBies** #5974 #5366
- **Visibility** - Fixes issue where `bottomPassed` and `topPassed` would not fire under some conditions
- **Dropdown** - Fixes issue where dropdowns might accidentally animate closed two times when quickly tabbing through fields
Expand Down
4 changes: 3 additions & 1 deletion src/definitions/modules/modal.less
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,9 @@
position: fixed;
}
.modals.dimmer .ui.scrolling.modal {
position: static !important;
position: relative !important;
left: auto !important;
top: auto !important;
margin: @scrollingMargin auto !important;
}

Expand Down

0 comments on commit aa1d36b

Please sign in to comment.