Fixes svg use with popup #3043

Semantic-Org · Nov 1, 2015 · 8ddd2ee · 8ddd2ee
1 parent 38a6aeb
commit 8ddd2ee
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md
@@ -29,6 +29,7 @@
 - **Grid** - Fixes attached segment 1px offset inside grid column #3226
 - **Grid** - Fixes some inconsistencies with `widescreen only` class #3161 **Thanks @mdehoog**
 - **Popup** - Fixes positioning issue when `movePopup: false` #3213 **Thanks @parisholley**
+- **Popup** - Popup now works with `svg` elements #3043
 - **Progress* - Calling `reset` will now reset `value` to 0, so increment starts again at 0
 - **Search** - Fixes `onSearchQuery` not firing when results are cached **Thanks @mnquintana**
 - **Search** - Fixes `url` parameter not working correctly due to typo in source **Thanks @fabienb4**

diff --git a/src/definitions/modules/popup.js b/src/definitions/modules/popup.js
@@ -697,7 +697,7 @@ $.fn.popup = function(parameters) {
             popup  = calculations.popup;
             parent = calculations.parent;
 
-            if(target.width === 0 && target.height === 0) {
+            if(target.width === 0 && target.height === 0 && !(target.element instanceof SVGGraphicsElement)) {
               module.debug('Popup target is hidden, no action taken');
               return false;
             }