Fix eventNamespace in #3396

Semantic-Org · Feb 20, 2018 · 3827fd0 · 3827fd0
1 parent e63201e
commit 3827fd0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md
@@ -33,7 +33,7 @@
 
 - **Popup** - Popup can now position elements correctly even when they have a different offset context than their activating element. Like in [this example](https://jsfiddle.net/g853mc03/).
 
-To preserve functionality `movePopup` has remained as `true` (moving the popup to the same offset context), however now setting `movePopup: false` should in all cases position correctly, helping prevent sticky inheritance issues caused by moving the DOM tree around.
+To preserve functionality `movePopup` default has remained as `true` (moving the popup to the same offset context), however now setting `movePopup: false` should now always position correctly. Be sure to use `movePopup: true` to avoid issues with `ui popup` inside `menu`, `input` or other places where it may inherit rules from its activating element or its context.
 
 - **Modal** - Modal has been rewritten to use `flexbox`. No need to call `refresh()` to recalculate vertical centering.
 - **Modal** - Modals now have a setting `centered` which can be used to disable vertical centering. This can be useful for modals with content that changes dynamically to prevent content from jumping in position.

diff --git a/src/definitions/modules/modal.js b/src/definitions/modules/modal.js
@@ -109,7 +109,7 @@ $.fn.modal = function(parameters) {
               defaultSettings = {
                 debug      : settings.debug,
                 variation  : settings.centered
-                  ? ''
+                  ? false
                   : 'top aligned'
                 ,
                 dimmerName : 'modals'
@@ -515,7 +515,7 @@ $.fn.modal = function(parameters) {
           },
           clickaway: function() {
             $dimmer
-              .off('click' + elementNamespace)
+              .off('click' + elementEventNamespace)
             ;
           },
           bodyStyle: function() {
@@ -615,7 +615,7 @@ $.fn.modal = function(parameters) {
           },
           clickaway: function() {
             $dimmer
-              .on('click' + elementNamespace, module.event.click)
+              .on('click' + elementEventNamespace, module.event.click)
             ;
           },
           dimmerSettings: function() {
@@ -627,10 +627,9 @@ $.fn.modal = function(parameters) {
               defaultSettings = {
                 debug      : settings.debug,
                 dimmerName : 'modals',
-                variation  : false,
                 closable   : 'auto',
                 variation  : settings.centered
-                  ? ''
+                  ? false
                   : 'top aligned'
                 ,
                 duration   : {