-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking(Portal|Popup): replace mouseOver event listener with mouseEnter #989
Conversation
Current coverage is 95.81% (diff: 100%)@@ master #989 diff @@
==========================================
Files 870 870
Lines 4801 4801
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 4600 4600
Misses 201 201
Partials 0 0
|
c6ccde3
to
ecb1e9d
Compare
9e959f7
to
4e55f0a
Compare
I know you're a busy fellow, any progress here @davezuko? Icon docs are borked without this guy. |
No, perhaps I will take a stab again tonight. There's a failing test or two that I'm absolutely stumped on, but maybe a fresh look will solve it. |
4e55f0a
to
3324c35
Compare
Cool, LMK. |
3324c35
to
e017826
Compare
Nice, this looks good. Want to add some breaking change notes as laid out in #978 (comment)? Also, the title will then be |
2f013a9
to
4db517a
Compare
4db517a
to
3f947da
Compare
@levithomason how is this? |
Looks great, thanks! |
Released in |
Breaking Change
Fixes #978.
This PR replaces all
mouseOver
-related<Portal />
events withmouseEnter
to be consistent withmouseLeave
. This affects the<Portal />
component directly, as well as any which implement it, which at this time includes<Popup />
.Upgrade Guide
All related
mouseOver
props should now bemouseEnter
. This will also impact the logic of these handlers since they are now only called when the element is entered, not (incorrectly) on enter and exit.BEFORE
AFTER