feat(Card): pass props to onClick #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #950 diff @@
====================================
Files 137 137
Lines 2279 2269 -10
Methods 0 0
Messages 0 0
Branches 0 0
====================================
- Hits 2279 2269 -10
Misses 0 0
Partials 0 0
|
levithomason
requested changes
Nov 28, 2016
| * tag by default instead of a `div`. | ||
| * | ||
| * @param {SyntheticEvent} event - React's original SyntheticEvent. | ||
| * @param {object} data - Relevant data. |
There was a problem hiding this comment.
I used the phrase "Relevant data" as an example to convey the intent in the spec, however, I think we should be as descriptive as possible in the actual docs. In this case, we can say data is props since that is all that is being passed.
jeffcarbs
force-pushed
the
feature/card-click
branch
from
aca603f
to
4a58c2f
Compare
|
@levithomason - updated 👍 |
levithomason
approved these changes
Nov 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #949