feat(customPropTypes): add suggest prop type checker #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #944 diff @@
====================================
Files 137 137
Lines 2269 2269
Methods 0 0
Messages 0 0
Branches 0 0
====================================
Hits 2269 2269
Misses 0 0
Partials 0 0
|
levithomason
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #936 and several other issues.
This PR:
suggestprop type checker for large lists of options (see below)Suggest best match
We now show the top 3 matches for Icon and Flag names. The
suggestprop type checker can be used on any large list of options.Forgiving className order
The
suggestchecker allowsright chevronto be considered valid against the valuechevron right. As long as all the words match every word in one of the options, the prop is considered valid.