fix(Portal): ignore document click if no node or portal #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
force-pushed
the
fix/portal-events
branch
from
4802a7a
to
d4367a1
Compare
|
@jcarbo sanity check? |
Closed
Current coverage is 100% (diff: 100%)@@ master #823 diff @@
====================================
Files 136 136
Lines 2217 2220 +3
Methods 0 0
Messages 0 0
Branches 0 0
====================================
+ Hits 2217 2220 +3
Misses 0 0
Partials 0 0
|
|
LGTM 👍 |
|
Released in |
layershifter
pushed a commit
that referenced
this pull request
Nov 11, 2016
* refactor(Portal): consolidate !open checks in renderPortal * fix(portal): clean up event handlers when re-rendering * fix(Portal): ignore document click if no node or portal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few fixes to the Portal, including one that should fix the IE Modal issue:
if (this.state.open)checks to therenderPortal()method, instead of checking every timerenderPortal()is called.portalevent handlers before adding duplicates inrenderPortal(), this should fix a memory leak