fix(package): do not access window/document in ssr #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
force-pushed
the
fix/document-access
branch
from
0f5d462
to
0d8194c
Compare
levithomason
force-pushed
the
fix/document-access
branch
from
0d8194c
to
a1accfc
Compare
levithomason
force-pushed
the
fix/document-access
branch
from
a1accfc
to
1ee8804
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #712
In server side rendering, there is not a valid
documentnorwindow. Accessing them will throw.This PR adds an
isBrowserutil. It then prevents calls to thedocumentandwindowin components if there is no browser present.P.S.
We might want to consider a
browsershim for this in the future instead. I can see it providing smarter access to thedocumentandwindow. It could also handle things like event pooling, #284.