fix(Accordion): respect defaultActiveIndex #763
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #761
The
defaultActiveIndex
is overridden in the Accordion oncomponentWillMount
. This PR adds an inline manual check for the default prop and a TODO to resolve the bug. I've also added 2 tests to assert the initial index of-1
and the default prop works correctly.This is an edge case, but we need to update the
AutoControlledComponent
to defer to default props when callingtrySetState
incomponentWillMount
.The real solve here is likely adding
static defaultAutoControlledProps
. Currently, theAutoControlledComponent
tells devs to usetrySetState
incomponentWillMount
instead of setting defaults for auto controlled props. This is to prevent the actual defaults from always winning, however, if we had our own auto controlled defaults then we could apply them correctly.