Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Table): add attached example #598

Merged
merged 2 commits into from
Oct 3, 2016
Merged

docs(Table): add attached example #598

merged 2 commits into from
Oct 3, 2016

Conversation

layershifter
Copy link
Member

This PR:

@codecov-io
Copy link

codecov-io commented Oct 3, 2016

Current coverage is 100% (diff: 100%)

Merging #598 into master will not change coverage

@@           master   #598   diff @@
====================================
  Files         119    119          
  Lines        1915   1915          
  Methods         0      0          
  Messages        0      0          
  Branches        0      0          
====================================
  Hits         1915   1915          
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last update 6c72147...3c541f2

@levithomason
Copy link
Member

levithomason commented Oct 3, 2016

Thanks much, reviewing.


P.S. Based on how the changelog is categorizing labels, I'm going to start labeling issues/PRs like so:

  • docs - for doc site changes (whether new docs, docs bug fix, or doc enhancement)
  • enhancement - new library features
  • bug - library bugs

@levithomason
Copy link
Member

levithomason commented Oct 3, 2016

I changed the export from:

const TableCelled = () => {
  return (

To:

const TableExampleAttached = () => (

I also reduced the LOC from 104 to 42. I'd like to keep examples as small as possible for easier doc site usage.

Will ship when tests pass.

@levithomason levithomason merged commit 7b5d2df into master Oct 3, 2016
@levithomason levithomason deleted the feat/table-docs branch October 3, 2016 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(Table): add attached example
4 participants