fix(Dropdown): fix search width #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 96.17% (diff: 100%)@@ master #443 diff @@
==========================================
Files 84 84
Lines 1252 1255 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1204 1207 +3
Misses 48 48
Partials 0 0
|
levithomason
force-pushed
the
fix/dropdown-search-width
branch
from
c777142
to
1a1a841
Compare
levithomason
force-pushed
the
fix/dropdown-search-width
branch
from
1a1a841
to
6b71bd3
Compare
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #397
Search type Dropdowns include a dynamically sized search input. This PR fixes the width measurement. It also fixes an issue where the Dropdown text was not muted when the search input is focused. This was due to rendering the
sizerwhen it was not needed. It is only necessary on multiple type Dropdowns.