Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): do not select disabled items on blur #4199

Merged
merged 4 commits into from
Jan 21, 2022

Conversation

tiangueu-cesar
Copy link
Contributor

fixed #3833.

with the fixed, any country having been deactivated could no longer make it possible to be selected. I took advantage of this opportunity and added the case a multiple selection:

@codecov-commenter
Copy link

codecov-commenter commented May 3, 2021

Codecov Report

Merging #4199 (6874d39) into master (ba0b20e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4199   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files         180      180           
  Lines        3244     3245    +1     
=======================================
+ Hits         3236     3237    +1     
  Misses          8        8           
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba0b20e...6874d39. Read the comment docs.

@layershifter layershifter changed the title added a variable to recognize if a country is blocked or not fix(Dropdown): do not select disabled items on blur Jan 21, 2022
@layershifter layershifter merged commit e500234 into Semantic-Org:master Jan 21, 2022
@welcome
Copy link

welcome bot commented Jan 21, 2022

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown: search & selection allows disabled options to be selected
3 participants