Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TextArea): update onChange type #4079

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

foooomio
Copy link
Contributor

@foooomio foooomio commented Sep 28, 2020

Fixes #4078

This replaces React.FormEvent with React.ChangeEvent for TextArea's onChange.

@welcome
Copy link

welcome bot commented Sep 28, 2020

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2020

Codecov Report

Merging #4079 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4079   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         183      183           
  Lines        3280     3280           
=======================================
  Hits         3275     3275           
  Misses          5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9399332...3bbe5ba. Read the comment docs.

@foooomio foooomio changed the title fix(TextArea): fix textarea onClick type fix(TextArea): fix textarea onChange type Sep 28, 2020
@layershifter layershifter changed the title fix(TextArea): fix textarea onChange type fix(TextArea): update onChange type Sep 28, 2020
Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@layershifter layershifter merged commit 9830ac6 into Semantic-Org:master Sep 28, 2020
@welcome
Copy link

welcome bot commented Sep 28, 2020

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@foooomio foooomio deleted the fix/textarea-type branch September 28, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript - TextArea onChange should provide ChangeEvent event
3 participants