chore: use lodash-es to improve bundle size #4072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…React into chore/lodash-es
size-limit report
|
Codecov Report
@@ Coverage Diff @@
## master #4072 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 183 183
Lines 3280 3280
=======================================
Hits 3275 3275
Misses 5 5 Continue to review full report at Codecov.
|
|
Just thought you might want to be aware of lodash/lodash#4879, I don't know what's going on there. |
|
@noinkling good call 🙁 Let's see how it will go, overall I would like to use less Lodash on our components. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces bundle size for projects that are using ES modules i.e. Webpack, Rollup, Next.js, Gatsby, etc. As SUIR depends on Lodash heavily the usage of
lodash-esallows to improve tree-shaking as ModuleConcatenationPlugin understands currently only ES modules.The solution was inspired by TSDx.
This may have negative impact on projects that are using
lodashdependency, feel free to leave feedback in this PR.