Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FormField): fix aria-invalid on error false #4043

Merged
merged 1 commit into from
Aug 19, 2020

Conversation

aoelen
Copy link
Contributor

@aoelen aoelen commented Aug 19, 2020

Fixes #4042

If error is false, <Form.Field error={false} /> aria-invalid is set to undefined. So it will not be present anymore. I also added some tests for aria-invalid

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2020

Codecov Report

Merging #4043 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4043   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         183      183           
  Lines        3276     3280    +4     
=======================================
+ Hits         3271     3275    +4     
  Misses          5        5           
Impacted Files Coverage Δ
src/collections/Form/FormField.js 100.00% <ø> (ø)
src/modules/Dropdown/Dropdown.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c24915...6fddcc7. Read the comment docs.

Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@layershifter
Copy link
Member

Can you please update your PR description to have Fixes #4042, this will auto close the issue?

https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@aoelen
Copy link
Contributor Author

aoelen commented Aug 19, 2020

Can you please update your PR description to have Fixes #4042, this will auto close the issue?

https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Sorry, forgot about that, just added it :)

@layershifter layershifter merged commit d0dc3c4 into Semantic-Org:master Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form field has aria-invalid attribute when error is false
3 participants