fix(Dropdown): fix handling of "Space" key #4041
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3146.
Fixes #3689.
This PR moves the handling of Spacebar to
Dropdown
's scope instead of the global scope withEventListener
. In any case these events should handled only whenDropdown
is focused.Another noticeable change is handling of Spacebar in
openOnSpace()
: now we will callpreventDefault()
only whene.target
is non-editable element and needs to prevent default behavior to avoid scrolling.