chore(MountNode): deprecate component #4027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
layershifter
commented
Aug 10, 2020
Codecov Report
@@ Coverage Diff @@
## master #4027 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 186 183 -3
Lines 3255 3275 +20
=======================================
+ Hits 3250 3270 +20
Misses 5 5
Continue to review full report at Codecov.
|
…React into chore/deprecate-mountnode
layershifter
changed the title
layershifter
commented
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks
MountNodeas deprecated, we will remove it in the next major release, i.e.2.0.0.The
MountNodecomponent was originally introduced in #2407. The main issue that is component should not be a part of the public API as it solves our specific issue with theModalcomponent.This PR internally replaces usages of
MountNodewithuseClassNamesOnNode()hook. The refactored version of utils does not use eitherlodashorlodash/fp, this allows to cut almost 30KB from bundled code 🎉This component will not be longer exported in V2.
If you are using this functionality, please make a follow up in this PR and we will export
useClassNamesOnNode().