fix(Dropdown): handle keyboard events for arrows, space and enter keys locally #4004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
Codecov Report
@@ Coverage Diff @@
## master #4004 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 184 184
Lines 3220 3233 +13
=======================================
+ Hits 3215 3228 +13
Misses 5 5
Continue to review full report at Codecov.
|
layershifter
commented
Jul 29, 2020
| @@ -8,7 +8,7 @@ const options = [ | |||
| ] | |||
|
|
|||
| const DropdownExampleDisabledItem = () => ( | |||
| <Dropdown text='Dropdown' options={options} open /> | |||
| <Dropdown text='Dropdown' options={options} /> | |||
There was a problem hiding this comment.
This Dropdown should not be be opened by default,
layershifter
commented
Jul 29, 2020
| @@ -52,28 +52,17 @@ export default class Dropdown extends Component { | |||
|
|
|||
| static getAutoControlledStateFromProps(nextProps, computedState, prevState) { | |||
| // These values are stored only for a comparison on next getAutoControlledStateFromProps() | |||
| const derivedState = { __value: nextProps.value, __options: nextProps.options } | |||
| const derivedState = { __options: nextProps.options, __value: computedState.value } | |||
There was a problem hiding this comment.
This should use computedState.value as we want to compute new selectedIndex based the component's state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3994.
This PR is focused on the single thing to move event handling from
document(i.e.EventStack) toDropdowns scope as it creates various issues when multipleDropdownare opened. And there are no reasons to have these listeners globally.