Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FormField): make form field error accessible #3822

Merged
merged 3 commits into from
Dec 8, 2019
Merged

feat(FormField): make form field error accessible #3822

merged 3 commits into from
Dec 8, 2019

Conversation

aoelen
Copy link
Contributor

@aoelen aoelen commented Oct 28, 2019

Fixes #3821

Form fields should have an id attribute in order for it to work (since aria-describedby needs an id).

Relates to: https://www.w3.org/WAI/WCAG21/quickref/?showtechniques=331#error-identification. More specifically, it relates to techniques: ARIA19 and ARIA21

@welcome
Copy link

welcome bot commented Oct 28, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work @aoelen , but it seems your checks were not successful , check it once.

@codecov-io
Copy link

codecov-io commented Nov 21, 2019

Codecov Report

Merging #3822 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3822      +/-   ##
==========================================
+ Coverage   99.83%   99.84%   +<.01%     
==========================================
  Files         172      177       +5     
  Lines        3101     3145      +44     
==========================================
+ Hits         3096     3140      +44     
  Misses          5        5
Impacted Files Coverage Δ
src/collections/Form/FormField.js 100% <100%> (ø) ⬆️
src/lib/createPaginationItems/suffixFactories.js 100% <0%> (ø)
src/lib/createPaginationItems/itemFactories.js 100% <0%> (ø)
...lib/createPaginationItems/createPaginationItems.js 100% <0%> (ø)
src/lib/createPaginationItems/paginationUtils.js 100% <0%> (ø)
src/lib/createPaginationItems/rangeFactories.js 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72c4508...f0405f4. Read the comment docs.

@levithomason
Copy link
Member

Thanks much and happy holidays 🎄 ☃️

@levithomason levithomason merged commit 9f797db into Semantic-Org:master Dec 8, 2019
@welcome
Copy link

welcome bot commented Dec 8, 2019

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form field errors are not accessible for screen readers
4 participants