-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FormField): make form field error accessible #3822
feat(FormField): make form field error accessible #3822
Conversation
💖 Thanks for opening this pull request! 💖 Here is a list of things that will help get it across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice Work @aoelen , but it seems your checks were not successful , check it once.
Codecov Report
@@ Coverage Diff @@
## master #3822 +/- ##
==========================================
+ Coverage 99.83% 99.84% +<.01%
==========================================
Files 172 177 +5
Lines 3101 3145 +44
==========================================
+ Hits 3096 3140 +44
Misses 5 5
Continue to review full report at Codecov.
|
Thanks much and happy holidays 🎄 ☃️ |
Fixes #3821
Form fields should have an id attribute in order for it to work (since aria-describedby needs an id).
Relates to: https://www.w3.org/WAI/WCAG21/quickref/?showtechniques=331#error-identification. More specifically, it relates to techniques: ARIA19 and ARIA21