Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(MenuExampleHeaderVertical): fix onClick handler #3799

Merged
merged 1 commit into from
Dec 8, 2019

Conversation

Suzi004
Copy link
Contributor

@Suzi004 Suzi004 commented Sep 30, 2019

handleItemClick = (e, { name }) => this.setState({ activeItem: name });

handleItemClick = (e, { name }) => this.setState({ activeItem: name });
@welcome
Copy link

welcome bot commented Sep 30, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

Codecov Report

Merging #3799 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3799   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files         172      172           
  Lines        3101     3101           
=======================================
  Hits         3096     3096           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72c4508...8a47419. Read the comment docs.

@levithomason levithomason changed the title docs(MenuExampleHeaderVertical): your description docs(MenuExampleHeaderVertical): fix onClick handler Dec 8, 2019
@levithomason levithomason merged commit 9a375ee into Semantic-Org:master Dec 8, 2019
@welcome
Copy link

welcome bot commented Dec 8, 2019

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants