-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MenuItem label propType to node #373
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 92.87% (diff: 100%)@@ master #373 diff @@
==========================================
Files 63 63
Lines 828 828
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 769 769
Misses 59 59
Partials 0 0
|
Cool, I did not know that. Will you make the change? |
I'll merge it, but I don't have rights to your fork. Easy win contribution if you like to push the update :) |
Sure, thanks. One minute please... |
levithomason
changed the title
MenuItem should accept an object for it's 'label' prop
Update MenuItem label propType to node
Aug 5, 2016
Thanks much! |
@levithomason Hi. Sorry, but I won't be able to take on |
It happens, thanks for the update @awei01. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
I have made this change to allow the label to be filled with some React component as well, in my case I needed to put in a "FormattedMessage" from the react-intl library to show a potentially translated label.